Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event cloning: add "update user data" checkbox #4750

Closed
pferreir opened this issue Jan 8, 2021 · 1 comment · Fixed by #4760
Closed

Event cloning: add "update user data" checkbox #4750

pferreir opened this issue Jan 8, 2021 · 1 comment · Fixed by #4760
Assignees
Projects
Milestone

Comments

@pferreir
Copy link
Member

pferreir commented Jan 8, 2021

Scenario:

  • User is added to an event;
  • User updates their profile data (on their profile page);
  • Someone else clones the aforementioned event;
  • Event still contains the old user data.

This is a pretty common source of misunderstandings. I suggest we add an "update user data" checkbox which will tell Indico to fetch the users' latest profile data upon cloning. I would also suggest to have that enabled by default.

@pferreir pferreir added this to the v3 milestone Jan 8, 2021
@pferreir pferreir changed the title Event clone: add "update user data" checkbox Event cloning: add "update user data" checkbox Jan 8, 2021
@ThiefMaster
Copy link
Member

Good idea. Since we can't really pass additional options to cloners (the only thing the user can choose is which cloners to run), I think we could work around this by adding another "pseudo cloner" for it which depends on the event persons cloner (and, if we want to wipe out all the override data stored on the person link level, also soft-depends on the contribution, session, etc. cloners) and instead of actually cloning anything just goes over the new event's persons and refreshes the data from the users.

Alternatively, we could make this just a separate option when cloning and then, after running all the cloners, refresh the data.

@ThiefMaster ThiefMaster added this to To do in Release 3.0 via automation Jan 11, 2021
@ThiefMaster ThiefMaster self-assigned this Jan 14, 2021
@ThiefMaster ThiefMaster moved this from To do to Awaiting review/merge in Release 3.0 Jan 14, 2021
Release 3.0 automation moved this from Awaiting review/merge to Done Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 3.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants