Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use signed URL instead of legacy API for persistent ical links #4776

Closed
ThiefMaster opened this issue Feb 9, 2021 · 0 comments · Fixed by #4801
Closed

Use signed URL instead of legacy API for persistent ical links #4776

ThiefMaster opened this issue Feb 9, 2021 · 0 comments · Fixed by #4801
Assignees
Projects
Milestone

Comments

@ThiefMaster
Copy link
Member

ThiefMaster commented Feb 9, 2021

We have this widget in various places within categories and events to get persistent URLs to an iCAL file:

image image

It is extremely legacy (see the code in Export.js) and using the (legacy) HTTPAPI for this is not ideal - let's use the signed URL utility we already use in the dashboard instead:

image

One thing to keep in mind is that we need to include the userid in the signature or the URL, since downloading the ical file needs to be tied to the user who created the token of course, since generally there won't be a valid session cookie when accessing the URL with the token.

We can also reconsider whether the persistent link actually makes sense in some of the places. For categories it's useful for sure, for events it may also be useful, but for sessions/contributions it's probably not really relevant.

@ThiefMaster ThiefMaster added this to the v3 milestone Feb 9, 2021
@ThiefMaster ThiefMaster added this to To do in Release 3.0 via automation Feb 9, 2021
@ThiefMaster ThiefMaster changed the title Use signed URL instead of legacy API for persistant ical links Use signed URL instead of legacy API for persistent ical links Feb 9, 2021
@javfg javfg moved this from To do to In progress in Release 3.0 Feb 17, 2021
Release 3.0 automation moved this from In progress to Done Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 3.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants