Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Team isn't allowed to see unpublished contributions #4811

Closed
plourenco opened this issue Mar 8, 2021 · 0 comments
Closed

Editing Team isn't allowed to see unpublished contributions #4811

plourenco opened this issue Mar 8, 2021 · 0 comments
Assignees
Labels
Projects
Milestone

Comments

@plourenco
Copy link
Member

When a user part of the editing team tries to access a contribution he's not part of, the following error will come up:
The contributions of this event have not been published yet.

Checking that specific controller RHContributionEditableBase, we call RHContributionDisplayBase which as:

if (not published and not self.event.can_manage(session.user)
                and not self.contrib.is_user_associated(session.user)):
    raise NotFound(_("The contributions of this event have not been published yet."))

can_manage doesn't include reviewing managers or paper editors. On the other hand, the editing team is also unable to see a contribution under RHContributionDisplayBase.

@plourenco plourenco added the bug label Mar 8, 2021
@ThiefMaster ThiefMaster added this to the v2.3 milestone Mar 9, 2021
@ThiefMaster ThiefMaster self-assigned this Mar 9, 2021
@ThiefMaster ThiefMaster added this to To do in Release 2.3 via automation Mar 9, 2021
Release 2.3 automation moved this from To do to Done Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Release 2.3
  
Done
Development

No branches or pull requests

2 participants