Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle email domains with SPF records #4837

Open
jjkeijser opened this issue Mar 23, 2021 · 3 comments
Open

Handle email domains with SPF records #4837

jjkeijser opened this issue Mar 23, 2021 · 3 comments

Comments

@jjkeijser
Copy link

With the advent of SPF records for many email domains, it is becoming harder and harder to send registration/invite emails from within Indico. For example, if a meeting organiser from an outside university wishes to send a reminder email but her university has SPF records set, then an email

  from:  professor@university.edu

will fail. A way around this is to add to send all emails from a domain you own (e.g. indico@nikhef.nl) with the reply-to field set to professor@university.edu .

How can this be added/configured in Indico v2.3.4+

@ThiefMaster
Copy link
Member

ThiefMaster commented Mar 23, 2021

No chance for v2.3.x... For a v3.x release (not sure if 3.0 is feasible unless someone opens a PR for this) we should indeed improve this.

I think something like this would make sense:

  • New indico.conf option, e,.g. SMTP_SENDER_DOMAINS:
    • True (or None?) for the current behavior (assume you can send from any domain used in Indico`
    • Otherwise a list of domains to allow any sender from that domain
  • If a domain is not authorized, then NO_REPLY_EMAIL will be used in From, and Reply-to will be set to the email that would otherwise be the From address. Populating the "human" part of the From header could be an option as well, but not sure how much spam filters like foo@bar.com <noreply@indico.tld> in a from header. It certainly smells like something malicious senders would use...

Not sure if we should use a Sender header in some cases...

related issues: #2224, #1877, (#3225)

@pferreir
Copy link
Member

I believe this is indeed a duplicate of #2224.

@jjkeijser
Copy link
Author

For the record: I added a workaround in the postfix configuration on our Indico server to rewrite the From: header and add a "Reply-To: header, and to make it nice I even copy over the "professor" name if specified. So, emails sent from

   from:  Some Prof <professor@university.edu>

are turned into

   from:  Some Prof <no-reply@...>
   reply-to: Some Prof <professor@university.edu>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants