Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of abstracts: filters are not well defined (missing "no value") #5033

Closed
t4nec0 opened this issue Aug 6, 2021 · 1 comment
Closed
Milestone

Comments

@t4nec0
Copy link

t4nec0 commented Aug 6, 2021

Bug Description
It's not possible to filter the of abstracts according to some fields where no values are wanted.

To Reproduce
Let's say that the admin adds a custom field (not visible to submitters) called "abstract state" for a custom workflow that enhances the Indico built in. For the sake of simplicity I consider here a radio button called "Abstract QA" with only one value: Yes. This is editable only by the admin, so by default this field will have no value at submission type.

Let's say that we have 100 abstracts submitted. The admin wants to "pre-accept" them by editing them and setting the "Abstract QA" field. This admin edits 80 abstracts and sets this field to YES, then stops.
Please note that at this editing stage the Abstract QA field actually has two values, even if only one was set: "No selection" and "Yes":

Selection_014

The day after, they want to QA the remaining 20 so they want to filter out all the other 80. They:

  1. go to Manage Abstracts
  2. click on Customise list
  3. try to select the one that still have NOT selected a Yes in Abstract QA:
    Selection_014
  4. realise that it's not possible to only list those that have NOT the "Yes" value in this field.

Expected behavior
Have a "No selection" option in the filter.

Additional context
Please note that the logic of other multi-value fields is not correct either: as an example, consider the abstracts state.
By default all abstracts are shown. By entering the "Customise list" panel and opening the State field, no options are selected which should mean "do not show any". If I select one, I only get that state. Idem for two. If I select all of them, I get back "any state", like when no state is selected. This means we have two possibilities for one filter (any) and no possibilities for another (no value for that field).

Expected behavior
By default that field filter should have all options selected. By deselecting all of them we'll get the abstracts with "no value" for that field. Or, different option, include a fictitious value "no selection" like in the abstracts editing.
The two areas should at least be consistent.

@t4nec0 t4nec0 added the bug label Aug 6, 2021
@ThiefMaster ThiefMaster added this to the v3 milestone Aug 10, 2021
@ThiefMaster
Copy link
Member

I disagree on selecting everything by default; but adding a "no value" fikter (additional checkbox) sounds like a very good idea! And it will be more flexible than "deselect everything" because it will allow you to filter e.g. by no value OR some specific other value at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants