New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access to badge design of a deleted category #5329

Closed

vasantvohra opened this issue Apr 21, 2022 · 1 comment · Fixed by #5334

Labels

bug

Milestone

Contributor

vasantvohra commented Apr 21, 2022

Reporting a hot bug, without much code scraping:

Create a SubCategory
Create a new badge from designer
You'll have link something like, http://127.0.0.1:9000/category/2/manage/designer/4/
Delete the subcategory
if you refresh the page http://127.0.0.1:9000/category/2/manage/designer/4/, the page is still accessible.

Probably, something needs to be fixed on check_access or process_args. Once I have time will open PR by tomorrow :)

vasantvohra added the bug label

Member

ThiefMaster commented Apr 21, 2022

Yeah, missing an if self.target.is_deleted: raise NotFound in SpecificTemplateMixin...

ThiefMaster added this to the v3.1 milestone

vasantvohra mentioned this issue

Prevent access to badge design of a deleted target #5334

Merged

ThiefMaster closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment