Skip to content

Status colours (buttons) do not correspond to the dots in the list (green/yellow/red vs green/yellow/orange) #5687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GovernmentPlates opened this issue Feb 22, 2023 · 0 comments · Fixed by #5697
Assignees

Comments

@GovernmentPlates
Copy link
Member

Priority: High
Deadline: 20230331

[BUG] status colours (buttons) do not correspond to the dots in the list (green/yellow/red vs green/yellow/orange). Button labels could be improved:
1. Accept -> Accept (green)
2. Make changes -> Editor made changes (yellow)
3. Request changes -> Request changes to author (red)

  • We can show a dot in the button and the dropdown instead of changing the color of the button.

Some additional details in following images:

Image

  • the "reject" status is normally BLACK in JACoW. Here it's purple-ish which is confusing. Could be confused with red or JACoW's purple (under editing):

Image

  • yellow appears yellow (which is good). The "Make changes" can be improved with "Editor made changes (yellow)" or a simple "Update/Replace (yellow) ":

Image

  • the red status is now orange... the text could be improved and changed to "Request changes to author (red)" or "Request author to make changes (red)"

Image

@GovernmentPlates GovernmentPlates converted this from a draft issue Feb 22, 2023
@GovernmentPlates GovernmentPlates self-assigned this Feb 22, 2023
@GovernmentPlates GovernmentPlates changed the title 1.17 - 20230331 - status colours (buttons) do not correspond to the dots in the list (green/yellow/red vs green/yellow/orange). Status colours (buttons) do not correspond to the dots in the list (green/yellow/red vs green/yellow/orange) Feb 22, 2023
@GovernmentPlates GovernmentPlates moved this from Todo to In Progress in JACoW suggestions to Indico Feb 23, 2023
@GovernmentPlates GovernmentPlates moved this from In Progress to Under Review in JACoW suggestions to Indico Mar 1, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done 🚀 in JACoW suggestions to Indico Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

1 participant