Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change the default reloader type #3150

Merged
merged 2 commits into from
Nov 16, 2017

Conversation

mic4ael
Copy link
Member

@mic4ael mic4ael commented Nov 14, 2017

No description provided.

@@ -146,6 +144,7 @@ def cleanup(temp, cache, assets, verbose, dry_run, min_age):
@click.option('--evalex-from', multiple=True,
help='Restrict the debugger shell to the given ips (can be used multiple times)')
@click.option('--proxy', is_flag=True, help='Use the ip and protocol provided by the proxy.')
@click.option('--reloader-type', default='auto', help='Use specific reloader type for your devserver.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use type=click.Choice(...) so people actually know what they can use. And maybe rename the option to --reloader

@@ -146,6 +144,8 @@ def cleanup(temp, cache, assets, verbose, dry_run, min_age):
@click.option('--evalex-from', multiple=True,
help='Restrict the debugger shell to the given ips (can be used multiple times)')
@click.option('--proxy', is_flag=True, help='Use the ip and protocol provided by the proxy.')
@click.option('--reloader', type=click.Choice(['auto', 'stat', 'watchdog']), default='auto',
help='Use specific reloader type for your devserver.')
Copy link
Member

@ThiefMaster ThiefMaster Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of auto-reloader to use.

your help text is missing a "the' but I think it can be made more concise like this since the whole command is for the dev server -> no need to mention it again

@mic4ael mic4ael force-pushed the reloader-type branch 2 times, most recently from 897dcef to e053e7c Compare November 16, 2017 13:53
@ThiefMaster ThiefMaster merged commit 3fca4b7 into indico:master Nov 16, 2017
@mic4ael mic4ael deleted the reloader-type branch November 16, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants