Event page: Add keywords to metadata in header #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
requested changes
Mar 12, 2018
| @@ -2,3 +2,6 @@ | |||
| <meta property="og:image" content="{{ event.logo_url if event.has_logo else | |||
| (indico_config.IMAGES_BASE_URL + '/logo_indico.png') }}"> | |||
| <meta property="og:description" content="{{ event.description|striptags|truncate(500) }}"> | |||
| {%- if event.keywords -%} | |||
| <meta keywords="{{ event.keywords|join(',') }}"> | |||
There was a problem hiding this comment.
I think the correct syntax is <meta name="keywords" value="...">
This line should be indented (we care about readable templates, even if this makes the final HTML output uglier).
Also, I think right now this ends up right behind the og:description line without a linebreak, so I would replace the -%} with %} or {%- with {%} (the - strips whitespace on the side where it is).
CHANGES.rst
Outdated
| @@ -65,6 +65,7 @@ Improvements | |||
| reviewing | |||
| - Show a nicer error message when entering an excessively high base | |||
| registration fee (:issue:`3260`) | |||
| - Add the keywords as meta tag to the page header(thanks :user:`bpedersen2`) | |||
There was a problem hiding this comment.
Missing space, and IMHO this can be a bit more concise:
- Expose event keywords through an HTML meta tag (:issue:`3262`, thanks
:user:`bpedersen2`)
|
There's a double space in your commit message (between |
pferreir
approved these changes
Mar 12, 2018
Currently the assigned keywords are only use in some calendar views, but for search engines they should also be provided in the keywords meta header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the assigned keywords are only use in some calendar views,
but for search engines they should also be provided in the keywords
meta header.