Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX pdfs: Allow link format customisation #3283

Merged
merged 2 commits into from Jul 18, 2019

Conversation

bpedersen2
Copy link
Contributor

@bpedersen2 bpedersen2 commented Apr 3, 2018

Make the hyperref link color options configurabable.

This is a more complete alternative to #3277

indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
indico/modules/events/abstracts/settings.py Outdated Show resolved Hide resolved
@bpedersen2
Copy link
Contributor Author

@bpedersen2 bpedersen2 commented Apr 19, 2018

Adressed all comments.

Copy link
Member

@ThiefMaster ThiefMaster left a comment

hey, please don't use the"resolve conflicts" button on GitHub. it adds a merge commit which makes things rather messy when merging the actual PR. better to just manually do a git rebase and then force push.

or ignore the conflicts, we'll rebase anyway before merging a PR

@ThiefMaster ThiefMaster added this to the v2.2 milestone May 23, 2018
@ThiefMaster ThiefMaster force-pushed the latexlinks branch 5 times, most recently from 32b8672 to 575473a Compare May 7, 2019
@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented May 7, 2019

I just rebased this PR to the latest master and fixed some things, but I noticed that "Color links (screen only)" also affects printing. I tested it with texlive 2018 (installing 2019 atm in case this fixes it).

Can you confirm that a printed PDF does not colorize links for you when using this option?

@bpedersen2
Copy link
Contributor Author

@bpedersen2 bpedersen2 commented Jun 19, 2019

Yes, seems like that depends on the pdf viewer used (I worked with Adobe Reader, but seems to have no effect with evince under linux).

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Jun 19, 2019

I think I tried with sumatrapdf (and possibly foxit reader as well) and it was printed there...

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Jun 19, 2019

Maybe it'd be better to remove that particular option since we have absolutely no control about which PDF viewer people use?

bpedersen2 and others added 2 commits Jul 18, 2019
Make the hyperref link color options configurabable.
Not supported in all pdf viewers :(
@ThiefMaster ThiefMaster merged commit 240c527 into indico:master Jul 18, 2019
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants