Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using dl, dt, dd HTML tags in editors #3325

Merged
merged 1 commit into from Apr 27, 2018

Conversation

@mvidalgarcia
Copy link
Member

@mvidalgarcia mvidalgarcia commented Apr 25, 2018

No description provided.

@@ -45,14 +45,14 @@
# basic list of tags, used for markdown content
BLEACH_ALLOWED_TAGS = bleach.ALLOWED_TAGS + [
'sup', 'sub', 'small', 'br', 'p', 'table', 'thead', 'tbody', 'th', 'tr', 'td', 'img', 'hr', 'h1', 'h2', 'h3', 'h4',
'h5', 'h6', 'pre'
'h5', 'h6', 'pre', 'dl', 'dd', 'dt'

This comment has been minimized.

@ThiefMaster

ThiefMaster Apr 25, 2018
Member

I don't think this change is necessary. For places where CKEditor fields are used, we use BLEACH_ALLOWED_TAGS_HTML

This comment has been minimized.

@mvidalgarcia

mvidalgarcia Apr 25, 2018
Author Member

render_markdown, which is being used in the contribution display page to print the description, uses BLEACH_ALLOWED_TAGS. This was the main reason of the change (RQF1001171).

This comment has been minimized.

@ThiefMaster

ThiefMaster Apr 25, 2018
Member

Ah I didn't realize it was there. I thought it was in the event description.

@ThiefMaster ThiefMaster force-pushed the mvidalgarcia:editor-dl branch from 59b6ed4 to 833b602 Apr 27, 2018
@ThiefMaster ThiefMaster merged commit 833b602 into indico:master Apr 27, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mvidalgarcia mvidalgarcia deleted the mvidalgarcia:editor-dl branch May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.