Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (friendly) registration id to designer fields #3370

Merged
merged 1 commit into from
May 30, 2018

Conversation

bpedersen2
Copy link
Contributor

This sometimes to allow to easily identify users during (manual) check-in.

@@ -268,6 +268,12 @@ def render(cls, registration):
return format_currency(registration.price, registration.currency, locale='en_GB')


class RegistrationIdPlaceholder(RegistrationPlaceholder):
name = 'registrationid'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registration_id or registration_friendly_id (if you go for the latter, also update the class name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -268,6 +268,12 @@ def render(cls, registration):
return format_currency(registration.price, registration.currency, locale='en_GB')


class RegistrationIdPlaceholder(RegistrationPlaceholder):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID instead of Id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bpedersen2 bpedersen2 force-pushed the designer_regid branch 2 times, most recently from 42a142c to fd7ebb8 Compare May 23, 2018 10:54
@ThiefMaster ThiefMaster changed the base branch from master to 2.1-maintenance May 30, 2018 14:12
@ThiefMaster ThiefMaster added this to the v2.1 milestone May 30, 2018
@ThiefMaster ThiefMaster merged commit 22a4013 into indico:2.1-maintenance May 30, 2018
@bpedersen2 bpedersen2 deleted the designer_regid branch June 1, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants