New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (friendly) registration id to designer fields #3370

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
2 participants
@bpedersen2
Contributor

bpedersen2 commented May 23, 2018

This sometimes to allow to easily identify users during (manual) check-in.

@@ -268,6 +268,12 @@ def render(cls, registration):
return format_currency(registration.price, registration.currency, locale='en_GB')


class RegistrationIdPlaceholder(RegistrationPlaceholder):
name = 'registrationid'

This comment has been minimized.

@ThiefMaster

ThiefMaster May 23, 2018

Member

registration_id or registration_friendly_id (if you go for the latter, also update the class name)

This comment has been minimized.

@bpedersen2

bpedersen2 May 23, 2018

Contributor

Done

@@ -268,6 +268,12 @@ def render(cls, registration):
return format_currency(registration.price, registration.currency, locale='en_GB')


class RegistrationIdPlaceholder(RegistrationPlaceholder):

This comment has been minimized.

@ThiefMaster

ThiefMaster May 23, 2018

Member

ID instead of Id

This comment has been minimized.

@bpedersen2

bpedersen2 May 23, 2018

Contributor

Done

@bpedersen2 bpedersen2 force-pushed the bpedersen2:designer_regid branch 2 times, most recently from 42a142c to fd7ebb8 May 23, 2018

@ThiefMaster ThiefMaster changed the base branch from master to 2.1-maintenance May 30, 2018

@ThiefMaster ThiefMaster added this to the v2.1 milestone May 30, 2018

@ThiefMaster ThiefMaster force-pushed the bpedersen2:designer_regid branch from fd7ebb8 to 22a4013 May 30, 2018

@ThiefMaster ThiefMaster merged commit 22a4013 into indico:2.1-maintenance May 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@bpedersen2 bpedersen2 deleted the bpedersen2:designer_regid branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment