Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import in registration API #3473

Merged
merged 1 commit into from Jul 30, 2018

Conversation

@femtobit
Copy link
Contributor

@femtobit femtobit commented Jul 26, 2018

While using a local Indico installation (version 2.1.2), I noticed that check-in did not work with the Indico Check-In Android app from Google Play Store. This was due to a NameError being thrown in line 61 here:

if 'checked_in' in request.json:
self._registration.checked_in = bool(request.json['checked_in'])
signals.event.registration_checkin_updated.send(self._registration)

Importing the signals module from indico.core fixes this.

@mic4ael
Copy link
Member

@mic4ael mic4ael commented Jul 26, 2018

I am curious how it got into the master. However this is a fix that should be merged into the branch 2-1.maintenance

@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Jul 26, 2018

Indeed, if you could rebase this PR onto 2.1-maintenance and change the upstream branch of your PR as well that would be great. Since this justifies a 2.1.3 release, I'll take the opportunity during the next few days to see which other small fixes/improvements we have in master that might be worth backporting now that there will be a 2.1.3 after all.

In any case, thanks for spotting and fixing this!

@femtobit femtobit changed the base branch from master to 2.1-maintenance Jul 26, 2018
@femtobit
Copy link
Contributor Author

@femtobit femtobit commented Jul 26, 2018

In any case, thanks for spotting and fixing this!

You're welcome. Thanks for the quick response.

As requested, I rebased unto 2.1-maintenance and changed the base branch of this PR accordingly.

@ThiefMaster ThiefMaster merged commit 8ef8ea5 into indico:2.1-maintenance Jul 30, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Jul 30, 2018

Thanks! We'll include this in a 2.1.3 bugfix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.