-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align footer-links in the center of the page #3599
Conversation
@@ -4,7 +4,7 @@ | |||
<a href="https://getindico.io">Indico</a> | |||
{%- endset -%} | |||
<div class="flexrow f-j-space-between"> | |||
<div class="flexrow f-a-center"> | |||
<div class="flexrow f-a-center f-self-stretch"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, why do we need to stretch the outer elements for this? Shouldn't space-between on the container already spread them evenly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all items have flex-grow
set to 1
, the remaining space in the container will be distributed equally to all children. In this case we have 3 children and we want the middle one to be at the exact center. So distributing the remaining space to the first and third child, we make sure that the 2nd one will always be in the middle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if the third element has no content ;)
yay, merged! |
Hey @nop33, I just noticed that this PR broke the footer logo text on the login page: I know it's not october anymore, but would you be willing to fix that? |
Sure, I can have a look! |
Pulled from Running Running
|
|
same result |
try deleting package-lock.json as well |
I did it right before I saw your comment. Worked, thx! |
I noticed that the footer links are clearly not in the center of the page and it seems like it was intended to be. This PR fixes this issue. To demonstrate:
Before
After
Also, is there a reason why the right padding of the footer is
5px
but the left is10px
inindico/web/client/styles/partials/_footer.scss
?