Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render paper state nicely #3665

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

pferreir
Copy link
Member

@pferreir pferreir commented Nov 20, 2018

Contrarily to what happens in the abstracts module, we currently render paper state quite plainly:

screenshot 2018-11-20 at 16 35 21

This commit makes it look a bit nicer:

screenshot 2018-11-20 at 16 33 41

screenshot 2018-11-20 at 16 31 38

and shows the number of reviews in the current paper revision as well:

screenshot 2018-11-20 at 16 33 37

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES.rst needs some love too!

@pferreir
Copy link
Member Author

@ThiefMaster done, thanks!

Copy link
Member

@mvidalgarcia mvidalgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the alignment from your screenshots is fixed.

@pferreir
Copy link
Member Author

pferreir commented Nov 20, 2018

@mvidalgarcia You assume wrong! I completely ignored that! 😉Thanks!

@pferreir pferreir merged commit 9ab88a2 into indico:2.1-maintenance Nov 20, 2018
@pferreir pferreir deleted the 2.1-maintenance branch November 20, 2018 16:42
@pferreir pferreir restored the 2.1-maintenance branch November 20, 2018 16:42
@pferreir pferreir deleted the 2.1-maintenance branch February 7, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants