Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in calendar view due to timezones #3903

Merged
merged 1 commit into from May 3, 2019

Conversation

@pferreir
Copy link
Member

commented Apr 23, 2019

Events starting next day due to the timezone were being wrongly
marked as "ongoing".

Internal ticket ref. INC1969641

@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

LGTM, just needs a changelog entry

@mvidalgarcia

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Some tests are failing. Apparently .dev domain is public now.

@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

ie unrelated to the PR. Anyway, I thought we had already removed .dev from that particular test?!

edit: oh, 2.1. not fixed there, and not worth backporting the fix

Fix bug in calendar view due to timezones
Events starting next day due to the timezone were being wrongly
marked as "ongoing".

@pferreir pferreir force-pushed the pferreir:fix-calendar-tz branch from 9e4a3c4 to b048cd3 May 3, 2019

@pferreir

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Pushed version with changelog entry. Ready to merge.

@pferreir pferreir requested a review from ThiefMaster May 3, 2019

@ThiefMaster ThiefMaster merged commit e69283c into indico:2.1-maintenance May 3, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@ThiefMaster ThiefMaster deleted the pferreir:fix-calendar-tz branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.