Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReactJS and SUIR globally #3955

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

panagiotappl
Copy link
Member

@panagiotappl panagiotappl commented Jun 4, 2019

Make sure indico css is not affected by SUIR

  • Use previous font-size in body instead of RB font-size
  • Remove border from main menu
  • Edit dropdown menu css to adapt to new changes
  • Fix font size in headers
  • Fix CSS in category statistics page
  • Fix box and line sizing in timetable rows and infogrids
  • Fix filter role dropdown in Participant roles
  • Fix search input in Particiapant roles & other places
  • Fix pencil icon in Lecture dispay view

Make sure SUIR components are compatible

  • Make Semantic UI React dropdowns compatible
  • Change indico .dropdown class to .i-dropdown
  • Fix SUIR inputs and checkbox labels css
  • Fix SUIR modal closeIcon now showing

Copy link
Member

@pferreir pferreir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work in an especially tricky task! I think that it may be worth preserving dropdown in the situations I've mentioned, if possible. Otherwise, there are a few question about some CSS changes, but I have nothing to say against them if there are no better solutions.

indico/modules/attachments/templates/_display.html Outdated Show resolved Hide resolved
indico/web/client/styles/base/_animation.scss Show resolved Hide resolved
indico/web/client/styles/base/_defaults.scss Outdated Show resolved Hide resolved
indico/web/client/styles/partials/_main.scss Show resolved Hide resolved
Copy link
Contributor

@meluru meluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 👍 good job! And the global menu looks much better now.

I've noticed two problems:

  • export dropdown in contributions list is broken,
    image
  • small issue, but search field in category picker has lost half of its height
    image

@panagiotappl panagiotappl force-pushed the css-import branch 2 times, most recently from 6e62e72 to 63e6b4b Compare August 7, 2019 09:18
@ThiefMaster
Copy link
Member

ThiefMaster commented Aug 7, 2019

When rebasing and removing the temp commit, can you please also add a changelog entry for 2.3 to the "Internal Changes" section?

- Make React and SemanticUI usable everywhere (:issue:`3955`)

Also, please fix the isort errors (unless they go away when removing the temp commit)

Use previous font-size in body instead of RB font-size
Remove border from main menu
Edit dropdown menu css to adapt to new changes
Remove React and SUIR from WPEventLogs bundle

Make sure indico css is not affected by SUIR:

Fix font size in headers
Fix CSS in category statistics page
Fix box and line sizing in timetable rows, infogrids, contribution
actions and role badges
Fix filter role dropdown
Fix input css

Make sure SUIR components are compatible:

Make Semantic UI React dropdowns compatible
Change indico .dropdown class to .i-dropdown
Fix SUIR inputs and checkbox labels css
Fix SUIR modal closeIcon now showing
@panagiotappl panagiotappl force-pushed the css-import branch 2 times, most recently from 8aaf71c to 27d8804 Compare August 7, 2019 10:24
@ThiefMaster ThiefMaster merged commit 0d40121 into indico:master Aug 7, 2019
@panagiotappl panagiotappl deleted the css-import branch August 19, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants