Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RB responsiveness 2.0 #4013

Merged
merged 24 commits into from Sep 24, 2019

Conversation

@mvidalgarcia
Copy link
Member

commented Jul 23, 2019

TODO
  • Investigate map issue
package.json Outdated Show resolved Hide resolved
indico/web/client/js/react/util/Responsive.jsx Outdated Show resolved Hide resolved
indico/web/client/js/react/hooks.js Outdated Show resolved Hide resolved
indico/web/client/js/react/hooks.js Outdated Show resolved Hide resolved
@mvidalgarcia mvidalgarcia force-pushed the mvidalgarcia:responsive2 branch from a04fb77 to 6db1a2a Jul 23, 2019
@mvidalgarcia mvidalgarcia marked this pull request as ready for review Jul 23, 2019
@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

The booking details tooltip on the calendar bars should probably be disabled on all touch devices (is there a media query for it)?


Can we hide more of the UI in portrait mode here? It looks a bit strange to have e.g. the legend there.

image

@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

More UI to hide in portrait mode:

image

@ThiefMaster

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

Error: Invalid LatLng object: (NaN, NaN)

I guess that's because the map is hidden? I don't think this happens if the map is generally disabled, so worth investigating why this happens here.

@mvidalgarcia mvidalgarcia force-pushed the mvidalgarcia:responsive2 branch from 6db1a2a to 63a7dba Jul 30, 2019
@mvidalgarcia mvidalgarcia force-pushed the mvidalgarcia:responsive2 branch from 7c4f853 to a28c8c1 Aug 6, 2019
@ThiefMaster ThiefMaster changed the base branch from master to 2.2-maintenance Aug 8, 2019
@mvidalgarcia mvidalgarcia force-pushed the mvidalgarcia:responsive2 branch 2 times, most recently from dc40f91 to 9ca300f Aug 8, 2019
@pferreir pferreir force-pushed the indico:2.2-maintenance branch from a1d01c6 to c5dd36f Aug 23, 2019
Copy link
Member

left a comment

The only things I noticed so far is a problem I encountered on my Phone (Galaxy S8)
There is no enough right margin in a few places which makes some elements partially invisible.

Screenshot_20190828-091856_Chrome

@mvidalgarcia mvidalgarcia force-pushed the mvidalgarcia:responsive2 branch 2 times, most recently from 9288bbf to f1c0a0c Sep 18, 2019
@mvidalgarcia

This comment has been minimized.

Copy link
Member Author

commented Sep 18, 2019

The only things I noticed so far is a problem I encountered on my Phone (Galaxy S8)
There is no enough right margin in a few places which makes some elements partially invisible.
[...]

Could you please check now and let me know? It's up on my server

@ThiefMaster ThiefMaster force-pushed the mvidalgarcia:responsive2 branch 2 times, most recently from 7d1e57f to 69b1d45 Sep 24, 2019
@ThiefMaster ThiefMaster force-pushed the mvidalgarcia:responsive2 branch from 69b1d45 to e7178e4 Sep 24, 2019
@ThiefMaster ThiefMaster merged commit e7178e4 into indico:2.2-maintenance Sep 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mvidalgarcia mvidalgarcia deleted the mvidalgarcia:responsive2 branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.