Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly log when a booking gets split in its log #4031

Merged
merged 2 commits into from Aug 16, 2019

Conversation

@ThiefMaster
Copy link
Member

commented Aug 15, 2019

Right now we have absolutely nothing in the log of any of the bookings when editing it resulted in a split, which leads to confused users (team members: see INC2082467) and wasted time for everyone involved when trying to figure out what happened.

We should log:

  • that the old booking has been split (ideally including the new booking ID even though we can't easily make it clickable). Maybe also log the new repetition/dates/times in the old booking?
  • in the new booking that it has been split from another booking (ideally also including the old booking ID)

Instead of the booking ID we could also include the link to the other booking... again, probably not clickable, but makes figuring out what happened so much easier...

@ThiefMaster ThiefMaster added this to the v2.2 milestone Aug 14, 2019

@ThiefMaster ThiefMaster self-assigned this Aug 15, 2019

ThiefMaster added 2 commits Aug 15, 2019
Fix flickering booking details tooltip
It covered its trigger element and immediately disappeared after opening
(chrome) or even flickered (firefox), making it basically unreadable.

@ThiefMaster ThiefMaster force-pushed the ThiefMaster:split-bookings-log branch from aa7a298 to a96114d Aug 15, 2019

@ThiefMaster ThiefMaster merged commit a96114d into indico:2.2-maintenance Aug 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ThiefMaster ThiefMaster deleted the ThiefMaster:split-bookings-log branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.