New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint that exports dashboard as ICS #4057
Conversation
I would strongly prefer the unique token, but in a different way; Store it on the User, and use it for all links of this kind (dashboard, category, etc); possibly through itsdangerous so the same token cannot be used on different links. The advantage compared to storing separate tokens is that getting those links is idempotent and getting them multiple times won't create new tokens (or have to check the DB whether a token for a specific link already exists). The only UI needed for that would be a "reset private links" button, telling the user that they have to update all links to protected dashboard, caetgory, etc. feeds they are using. Speaking of category feeds: this would be a good opportunity to rip out the connection to the HTTP API from category/event ical links and use the token there - that's a bunch of legacy JS that could go away (currently we have stuff like creating an API key and enabling persistent api signatures in there). |
722e319
to
f19b1e3
Compare
indico/modules/users/client/js/react/components/ICSCalendarLink.jsx
Outdated
Show resolved
Hide resolved
indico/modules/users/client/js/react/components/ICSCalendarLink.jsx
Outdated
Show resolved
Hide resolved
indico/modules/users/client/js/react/components/ICSCalendarLink.jsx
Outdated
Show resolved
Hide resolved
indico/modules/users/client/js/react/components/ICSCalendarLink.jsx
Outdated
Show resolved
Hide resolved
indico/migrations/versions/20190925_1548_229bb73a558a_add_signature_token_column_to_user.py
Outdated
Show resolved
Hide resolved
indico/modules/users/client/js/react/components/ICSCalendarLink.jsx
Outdated
Show resolved
Hide resolved
7641eeb
to
0c43ff4
Compare
e303669
to
aae2cfe
Compare
I also made the dashboard a little bit less claustrophobic and more readable (and responsive!):
