Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint that exports dashboard as ICS #4057

Merged
merged 9 commits into from Oct 22, 2019

Conversation

pferreir
Copy link
Member

@pferreir pferreir commented Sep 9, 2019

image

image

I also made the dashboard a little bit less claustrophobic and more readable (and responsive!):
image

@ThiefMaster
Copy link
Member

ThiefMaster commented Sep 9, 2019

I would strongly prefer the unique token, but in a different way; Store it on the User, and use it for all links of this kind (dashboard, category, etc); possibly through itsdangerous so the same token cannot be used on different links.

The advantage compared to storing separate tokens is that getting those links is idempotent and getting them multiple times won't create new tokens (or have to check the DB whether a token for a specific link already exists).

The only UI needed for that would be a "reset private links" button, telling the user that they have to update all links to protected dashboard, caetgory, etc. feeds they are using.

Speaking of category feeds: this would be a good opportunity to rip out the connection to the HTTP API from category/event ical links and use the token there - that's a bunch of legacy JS that could go away (currently we have stuff like creating an API key and enabling persistent api signatures in there).

indico/modules/users/controllers.py Outdated Show resolved Hide resolved
indico/modules/users/controllers.py Outdated Show resolved Hide resolved
indico/modules/users/controllers.py Outdated Show resolved Hide resolved
indico/util/marshmallow.py Outdated Show resolved Hide resolved
@pferreir pferreir requested review from mic4ael and ThiefMaster Sep 25, 2019
@pferreir pferreir force-pushed the add-dashboard-ics branch 3 times, most recently from 722e319 to f19b1e3 Compare Sep 25, 2019
indico/modules/users/models/users.py Outdated Show resolved Hide resolved
indico/modules/users/client/js/dashboard.js Outdated Show resolved Hide resolved
indico/modules/users/models/users.py Outdated Show resolved Hide resolved
indico/web/util.py Outdated Show resolved Hide resolved
indico/web/util.py Show resolved Hide resolved
indico/modules/users/controllers.py Outdated Show resolved Hide resolved
indico/modules/users/models/users.py Outdated Show resolved Hide resolved
indico/modules/api/templates/user_profile.html Outdated Show resolved Hide resolved
indico/web/util.py Outdated Show resolved Hide resolved
indico/modules/users/client/js/dashboard.jsx Show resolved Hide resolved
indico/modules/users/client/js/dashboard.jsx Show resolved Hide resolved
indico/web/util.py Outdated Show resolved Hide resolved
indico/web/util.py Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@pferreir pferreir force-pushed the add-dashboard-ics branch 3 times, most recently from 7641eeb to 0c43ff4 Compare Oct 21, 2019
indico/modules/core/controllers.py Outdated Show resolved Hide resolved
@ThiefMaster
Copy link
Member

ThiefMaster commented Oct 22, 2019

image

Truncating the title at 50% width is a bit strange now

@pferreir pferreir force-pushed the add-dashboard-ics branch 3 times, most recently from e303669 to aae2cfe Compare Oct 22, 2019
@pferreir pferreir merged commit 3577565 into indico:master Oct 22, 2019
1 check was pending
@pferreir pferreir deleted the add-dashboard-ics branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants