Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning ACL involving event roles links to role from source event. #4090

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@ThiefMaster
Copy link
Member

commented Oct 2, 2019

When cloning an event that has event roles in the ACL, the new event will still reference the event roles from the old event. We need to clone any event roles that are used in an ACL instead (or just clone all of them when using the EventProtectionCloner since they are kind of related to "ACLs and protection settings" anyway)

https://talk.getindico.io/t/participant-role-clone-problem/1452


Added an explicit "Event roles" cloner option, and depending on whether it's selected or not, role entries in the ACLs will either be skipped or correctly cloned (with a reference to the cloned event role).

Also added a new CLI command indico maint fix-event-role-acls which fixes any ACL entries that reference a role from another event.

@ThiefMaster ThiefMaster added this to the v2.2 milestone Sep 30, 2019
@ThiefMaster ThiefMaster self-assigned this Sep 30, 2019
@ThiefMaster ThiefMaster requested review from mic4ael and pferreir Oct 2, 2019
@mic4ael
mic4ael approved these changes Oct 3, 2019
indico/modules/events/roles/clone.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster force-pushed the ThiefMaster:clone-event-roles branch from e85042b to 2416ec9 Oct 3, 2019
@ThiefMaster ThiefMaster changed the base branch from master to 2.2-maintenance Oct 3, 2019
@ThiefMaster ThiefMaster force-pushed the ThiefMaster:clone-event-roles branch from 13f1ae2 to ea0f016 Oct 3, 2019
@ThiefMaster ThiefMaster requested a review from mic4ael Oct 3, 2019
@ThiefMaster ThiefMaster force-pushed the ThiefMaster:clone-event-roles branch from ea0f016 to 0312e59 Oct 3, 2019
@ThiefMaster ThiefMaster merged commit e0f96c0 into indico:2.2-maintenance Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ThiefMaster ThiefMaster deleted the ThiefMaster:clone-event-roles branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.