Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft mode for contributions/timetable #4095

Merged
merged 9 commits into from Oct 22, 2019

Conversation

panagiotappl
Copy link
Member

@panagiotappl panagiotappl commented Oct 2, 2019

closes #4056

TODO:

  • Write proper modal text

indico/modules/events/contributions/__init__.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/__init__.py Outdated Show resolved Hide resolved
const [modalOpen, setModalOpen] = useState(false);

useEffect(() => {
const fetchPublicationSetting = async () => {
Copy link
Member

@mic4ael mic4ael Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why this function has been defined inside the useEffect callback? Even though this effect will not be called more than once (since confId will not change) I think it would be nice to move the function outside of the callback and then you could also remove the confId from the useEffect dependencies.

Copy link
Member

@ThiefMaster ThiefMaster Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the eventId should stay in the dependency list. In the case of the prop changing to another ID (even if that's not gonna happen), you want to reload the data for the new ID.

@panagiotappl panagiotappl force-pushed the disable-contributions branch 2 times, most recently from f465ee4 to 823d237 Compare Oct 4, 2019
indico/modules/events/abstracts/controllers/boa.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/blueprint.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/client/js/index.js Outdated Show resolved Hide resolved
indico/modules/events/contributions/client/js/index.js Outdated Show resolved Hide resolved
indico/modules/events/contributions/client/js/index.js Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster changed the title Disable contributions Add draft mode for contributions/timetable Oct 4, 2019
@panagiotappl panagiotappl marked this pull request as ready for review Oct 7, 2019
@panagiotappl panagiotappl force-pushed the disable-contributions branch 3 times, most recently from dfd7b16 to a0a2f40 Compare Oct 10, 2019
@ThiefMaster ThiefMaster merged commit cb019f9 into indico:master Oct 22, 2019
1 check passed
@panagiotappl panagiotappl deleted the disable-contributions branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants