Add draft mode for contributions/timetable #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Oct 2, 2019
mic4ael
reviewed
Oct 3, 2019
| const [modalOpen, setModalOpen] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const fetchPublicationSetting = async () => { |
There was a problem hiding this comment.
Is there any reason why this function has been defined inside the useEffect callback? Even though this effect will not be called more than once (since confId will not change) I think it would be nice to move the function outside of the callback and then you could also remove the confId from the useEffect dependencies.
There was a problem hiding this comment.
I think the eventId should stay in the dependency list. In the case of the prop changing to another ID (even if that's not gonna happen), you want to reload the data for the new ID.
panagiotappl
force-pushed
the
disable-contributions
branch
2 times, most recently
from
f465ee4
to
823d237
Compare
ThiefMaster
requested changes
Oct 4, 2019
ThiefMaster
changed the title
panagiotappl
force-pushed
the
disable-contributions
branch
from
823d237
to
3bd929e
Compare
mic4ael
reviewed
Oct 7, 2019
panagiotappl
force-pushed
the
disable-contributions
branch
3 times, most recently
from
dfd7b16
to
a0a2f40
Compare
ThiefMaster
requested changes
Oct 21, 2019
ThiefMaster
approved these changes
Oct 22, 2019
Make code improvements
panagiotappl
force-pushed
the
disable-contributions
branch
from
fd0aa49
to
98dd876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
closes #4056
TODO: