Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registrations to print_badge_template signal #4297

Closed
wants to merge 1 commit into from

Conversation

giusedb
Copy link
Contributor

@giusedb giusedb commented Feb 18, 2020

This PR adds an argument registrations to the indico.core.signals.events.designer.print_badge_template.
The newly added argument registrations contains the list of Registration objects for which badges are printed.

Copy link
Member

@ThiefMaster ThiefMaster left a comment

Just as a suggestion, it's better to use separate branches for future PRs - that way you can just fast-forward your own master once it's merged.

Called when printing a badge template. The registration form is passed in the `regform` kwarg.
Called when printing a badge template.
The registration form is passed in the `regform` kwarg.
The registration objects are passed in the `registrations` kwargs
Copy link
Member

@ThiefMaster ThiefMaster Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwarg instead of kwargs

Copy link
Contributor Author

@giusedb giusedb Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kwarg typo fixed

Copy link
Member

@ThiefMaster ThiefMaster Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you changed it the wrong way round ;) it should be "kwarg", not "kwargs" (since each sentence references a single kwarg).

Copy link
Contributor Author

@giusedb giusedb Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

@ThiefMaster
Copy link
Member

ThiefMaster commented Feb 19, 2020

I've amended the commit with the proper typo fix and merged it into our master. Please make sure to rebase your own master branch (it's 6w old!) so you get the correct commit from us.

@giusedb
Copy link
Contributor Author

giusedb commented Feb 19, 2020

Thank you @ThiefMaster !

Leats pushed a commit to Leats/indico that referenced this issue Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants