Events visibility

[openprojects]

Show/hide Events in Category based on can_display

[ThiefMaster]

What do you think about not checking for event management permissions but only category management permissions when determining whether to show hidden events anyway or not? This would allow making this much simpler as you could always hide events with visibility==0 unless you are a category manager (ie you can do this fully on the query level without and extra queries etc)!

I think this would cover the most common cases, and we could always show a notice on the protection page when setting the event's visibility to "Invisible" mentioning that only category managers can see the event, and others can only access it via a direct link or from their profile dashboard.

[openprojects]

… but then any Conference Manager (and other custom role we will create, like “Security manager”) will not see the Event he should be able to manage…

…

___________________________________ Giorgio Pieretti (Mr.) Information Systems Assistant Division of Conference Management (DCM) United Nations Office in Geneva (UNOG) Palais des Nations, Room E-164 1211 Geneva 10 Tel. +41 22 917 2691 Mobile +41 79 444 39 43 e-mail: giorgio.pieretti@un.org<mailto:giorgio.pieretti@un.org> website: www.unog.ch<http://www.unog.ch/> From: Adrian <notifications@github.com> Reply-To: indico/indico <reply@reply.github.com> Date: Tuesday, 21 April 2020 at 12:16 To: indico/indico <indico@noreply.github.com> Cc: Giorgio Pieretti <giorgio.pieretti@un.org>, Author <author@noreply.github.com> Subject: Re: [indico/indico] Events visibility (#4419) What do you think about not checking for event management permissions but only category management permissions when determining whether to show hidden events anyway or not? This would allow making this much simpler as you could always hide events with visibility==0 unless you are a category manager (ie you can do this fully on the query level without and extra queries etc)! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#4419 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA5KGIU7CO44KXO6IQTKGWTRNVW77ANCNFSM4MNFJEJA>.

[ThiefMaster]

Yeah, depends on whether it's common to have managers that aren't category managers... I guess in your case this happens more often so having the event-level check probably indeed makes sense...

[openprojects]

Exactly. I proceed fixing the PR. Thank you!

…

___________________________________ Giorgio Pieretti (Mr.) Information Systems Assistant Division of Conference Management (DCM) United Nations Office in Geneva (UNOG) Palais des Nations, Room E-164 1211 Geneva 10 Tel. +41 22 917 2691 Mobile +41 79 444 39 43 e-mail: giorgio.pieretti@un.org<mailto:giorgio.pieretti@un.org> website: www.unog.ch<http://www.unog.ch/> From: Adrian <notifications@github.com> Reply-To: indico/indico <reply@reply.github.com> Date: Tuesday, 21 April 2020 at 12:24 To: indico/indico <indico@noreply.github.com> Cc: Giorgio Pieretti <giorgio.pieretti@un.org>, Author <author@noreply.github.com> Subject: Re: [indico/indico] Events visibility (#4419) Yeah, depends on whether it's common to have managers that aren't category managers... I guess in your case this happens more often so having the event-level check probably indeed makes sense... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#4419 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA5KGIXK4AVZ66Q7UHP5GK3RNVX3BANCNFSM4MNFJEJA>.

[ThiefMaster]

You are not correctly checking for hidden events when loading past/future events (RHEventList).

[ThiefMaster]

Please update the field description of the event visibility field to mention that "Invisible" also hides the event from the category list

[openprojects]

You are not correctly checking for hidden events when loading past/future events (RHEventList).

OK... from the category view I don't hit that class... where can I reproduce it?

[ThiefMaster]

Just move the event's date long enough in the past that it's part of the "past events" that are loaded with a separate request

[openprojects]

Please update the field description of the event visibility field to mention that "Invisible" also hides the event from the category list

Sure. Should I also update the msgid in the .po files? and the relative translations too (BR,FR,ES)?

[ThiefMaster]

no, we do that later when coming closer to a release

[openprojects]

Is there anything else I have to change/fix in the PR?

[ThiefMaster]

no, looks good. i'll give it a last quick test tomorrow, add a changelog entry and then merge it

[ThiefMaster]

I pushed some small fixes/improvements; the most important one was including visibility in the list of queried columns when querying the events - without this there was one extra query for each event, making this whole check very slow for large categories.