Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resetting registration moderation status #4498

Merged
merged 3 commits into from Jun 24, 2020

Conversation

OmeGak
Copy link
Member

@OmeGak OmeGak commented Jun 17, 2020

This PR introduces the possibility for managers to reset the approval state of a given registration from the registration details view. The button is displayed as part of available actions for "complete" registrations only if registration form moderation is enabled.

Screenshot

image

@ThiefMaster
Copy link
Member

ThiefMaster commented Jun 18, 2020

Resetting a rejected or withdrawn (even if there's no UI for the latter) registration is not possible yet

@OmeGak OmeGak changed the title Allow resetting approval from registration view Allow resetting registration moderation status Jun 18, 2020
@OmeGak
Copy link
Member Author

OmeGak commented Jun 18, 2020

Resetting a rejected or withdrawn (even if there's no UI for the latter) registration is not possible yet

Rejected state is now properly handled.

@OmeGak OmeGak force-pushed the wip/reg-set-pending branch 2 times, most recently from 001e9ec to ebd4b91 Compare Jun 18, 2020
@ThiefMaster ThiefMaster requested a review from pferreir Jun 22, 2020
@OmeGak OmeGak force-pushed the wip/reg-set-pending branch 2 times, most recently from 37aac15 to 136fa46 Compare Jun 23, 2020
@ThiefMaster
Copy link
Member

ThiefMaster commented Jun 24, 2020

When the registration is in the unpaid state the reset approval button is not visible.
After marking it as paid, it shows up, but clicking it doesn't do anything...

@OmeGak
Copy link
Member Author

OmeGak commented Jun 24, 2020

Fixed:

  • The button is now hidden when a registration is complete and paid.
  • The button is now displayed when a registration is unpaid.

ThiefMaster added 2 commits Jun 24, 2020
- allow resetting rejecting even after disabling moderation
- if payment is required, go to unpaid instead of complete
@ThiefMaster ThiefMaster merged commit 2af49fb into indico:master Jun 24, 2020
4 checks passed
@ThiefMaster ThiefMaster deleted the wip/reg-set-pending branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants