-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow filtering event log by related entries #4503
Conversation
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
6a77b72
to
7afbfcf
Compare
0525300
to
5d98a81
Compare
598e53c
to
9ede332
Compare
700dcd1
to
3ffc39c
Compare
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
I noticed that we are not attaching the registration id when logging emails related to a registration. I thing doing it there too would be a good idea. You'll have to add a way to pass-through internal data (maybe call it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the PR! 👍 I have left a few comments, nothing too critical, mostly about the naming of some stuff.
indico/migrations/versions/20200623_1718_05f227f4b938_add_internal_data_to_event_logs.py
Outdated
Show resolved
Hide resolved
257d2ce
to
e1e30e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This works great! I only have a few minor suggestions below.
e1e30e0
to
fa73f2e
Compare
fa73f2e
to
29eb4d0
Compare
Done! |
bc7aa07
to
7afdbd3
Compare
indico/modules/events/logs/client/js/components/LogEntryModal.jsx
Outdated
Show resolved
Hide resolved
indico/modules/events/logs/client/js/containers/LogEntryModal.js
Outdated
Show resolved
Hide resolved
e103860
to
6e116ba
Compare
Also, allow filtering by `meta` in RHEventLogsJSON.
This allows querying by specific registration in event logs.
6e116ba
to
6dbdc19
Compare
Event log filtering by related entries relies on the new
internal_data
column added to theevent.logs
table. For now, the only logged events that use this new column are those related to registrations.Screenshots