Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering event log by related entries #4503

Merged
merged 5 commits into from
Jul 2, 2020

Conversation

OmeGak
Copy link
Member

@OmeGak OmeGak commented Jun 23, 2020

Event log filtering by related entries relies on the new internal_data column added to the event.logs table. For now, the only logged events that use this new column are those related to registrations.

Screenshots

image
image

@OmeGak OmeGak force-pushed the wip/event-log-data branch 3 times, most recently from 6a77b72 to 7afbfcf Compare June 24, 2020 10:43
@OmeGak OmeGak marked this pull request as ready for review June 24, 2020 10:43
@OmeGak OmeGak force-pushed the wip/event-log-data branch 2 times, most recently from 0525300 to 5d98a81 Compare June 25, 2020 09:29
@ThiefMaster ThiefMaster marked this pull request as draft June 25, 2020 12:37
@OmeGak OmeGak force-pushed the wip/event-log-data branch 3 times, most recently from 598e53c to 9ede332 Compare June 25, 2020 15:47
@OmeGak OmeGak force-pushed the wip/event-log-data branch 5 times, most recently from 700dcd1 to 3ffc39c Compare June 29, 2020 14:07
@OmeGak OmeGak changed the title Save registration ID in event logs Allow filtering event log by related entries Jun 29, 2020
@OmeGak OmeGak marked this pull request as ready for review June 29, 2020 14:18
@ThiefMaster
Copy link
Member

I noticed that we are not attaching the registration id when logging emails related to a registration. I thing doing it there too would be a good idea.

You'll have to add a way to pass-through internal data (maybe call it log_data there?) in send_email and _log_email; the rest should be straightforward.

Copy link
Member

@pferreir pferreir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the PR! 👍 I have left a few comments, nothing too critical, mostly about the naming of some stuff.

@OmeGak OmeGak force-pushed the wip/event-log-data branch 3 times, most recently from 257d2ce to e1e30e0 Compare June 30, 2020 16:40
Copy link
Member

@plourenco plourenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works great! I only have a few minor suggestions below.

@OmeGak
Copy link
Member Author

OmeGak commented Jul 1, 2020

I noticed that we are not attaching the registration id when logging emails related to a registration. I thing doing it there too would be a good idea.

Done!

@OmeGak OmeGak force-pushed the wip/event-log-data branch 2 times, most recently from bc7aa07 to 7afdbd3 Compare July 1, 2020 14:00
@OmeGak OmeGak force-pushed the wip/event-log-data branch 5 times, most recently from e103860 to 6e116ba Compare July 2, 2020 09:32
Also, allow filtering by `meta` in RHEventLogsJSON.
This allows querying by specific registration in event logs.
@ThiefMaster ThiefMaster merged commit cefd5b4 into indico:master Jul 2, 2020
@OmeGak OmeGak deleted the wip/event-log-data branch July 2, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants