Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template hook to event management title #4504

Merged

Conversation

meluru
Copy link
Contributor

@meluru meluru commented Jun 25, 2020

  • Adds event-management-after-title template hook
  • Fixes banner class margins

@meluru meluru force-pushed the wip/event-management-title-hook branch from 900313a to 49c23e9 Compare Jun 25, 2020
@ThiefMaster
Copy link
Member

ThiefMaster commented Jun 25, 2020

Looks fine. What exactly are you fixing in the banner margins? And example how it's broken without the fix? I see a tiny (1px or something in that area) shift between master and your branch, but nothing significant.

@meluru
Copy link
Contributor Author

meluru commented Jun 25, 2020

When we add more content to the banner with the hook, 10% is more than 19px and things overlap.

@ThiefMaster
Copy link
Member

ThiefMaster commented Jun 25, 2020

OK, makes sense. I was afraid the fix would break the alignment fixed in #4389 but that's not the case so everything is ok!

However, I don't think this fix needs a changelog entry since it's not broken in the core, and the hook also did not exist in a previous version.

@meluru meluru force-pushed the wip/event-management-title-hook branch from 49c23e9 to 0e6634a Compare Jun 25, 2020
@meluru
Copy link
Contributor Author

meluru commented Jun 25, 2020

Great! I've removed the changelog entry.

@ThiefMaster ThiefMaster merged commit e513450 into indico:master Jun 25, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants