Import from event feature #4533

meluru · 2020-07-15T08:36:08Z

ThiefMaster

Thanks, this is already looking really nice! I just left a few comments about things i noticed when having a quick look.

indico/modules/events/cloning.py

indico/modules/events/operations.py

plourenco

I've been manually checking most of the import conflicts and available conditions and this seems to be working well! 👍 I just added some notes below on the causes for features I wasn't able to import.

CHANGES.rst

indico/modules/events/contributions/clone.py

indico/modules/events/clone.py

meluru · 2020-07-29T11:36:42Z

@plourenco Thank you for the review, it was a good catch indeed.
All updated now.

plourenco

Works fine here. Looks very close to being ready! 👍 I just added a few notes regarding the last commit.

I also noticed the import dialog seems to output both messages even before any content, perhaps something was changed here in the last push?

CHANGES.rst

indico/modules/events/editing/clone.py

meluru · 2020-07-30T09:28:58Z

@plourenco
I didn't manage to reproduce this problem here and nothing changed ui-wise in the last push.
Does it always happen for you? Maybe it's some corner case or it's browser-specific?

plourenco

I can no longer reproduce the problem with the dialog, must have been a change I did while testing the last commit.

Thanks!! 🎉

indico/modules/events/management/forms.py

indico/core/signals/event/core.py

indico/modules/attachments/clone.py

indico/modules/categories/schemas.py

indico/modules/events/clone.py

indico/modules/events/cloning.py

indico/modules/events/contributions/clone.py

indico/modules/events/management/blueprint.py

indico/modules/events/management/controllers/cloning.py

meluru · 2020-08-04T11:54:26Z

All updated now! I removed all friendly_id related changes and fixed the index on sessions.

indico/migrations/versions/20200804_1308_497c61b68050_fix_session_friendly_id_index.py

plourenco · 2020-08-06T10:43:03Z

It would be an interesting idea if we added an indication on why some fields are greyed out, as in: "You can't import because you already made changes there" or "Only unmodified/empty modules of the event can be imported". Could even be something generic, it would be more user friendly.

meluru · 2020-08-07T09:03:40Z

@plourenco that's a good point. I'll add a message. 👍 I think I should also remove from the list the modules that don't support importing at all, because having them greyed out might be confusing.

meluru · 2020-08-11T10:27:48Z

Updated. Let me know if the message is alright.

ThiefMaster · 2020-08-14T09:51:36Z

I pushed some small fixes/improvements I noticed while testing.

When trying to import the timetable from a larger event from the past (indico workshop 2.0) I'm currently getting an error about the timetable being inconsistent; I'll have a look and see if it's a quick fix, otherwise I'll ask you to look into it :p

ThiefMaster · 2020-08-14T09:59:18Z

The timetable error happens because my target event was shorter. Should we make it a conflict in the timetable importer when the source event is longer than the target event?

ThiefMaster · 2020-08-14T10:14:35Z

I added a commit doing just that. Importing the indico workshop event works fine now, I'll test with some other events but I think it's pretty much ready to be merged!

ThiefMaster · 2020-08-14T10:32:58Z

After discussing with the team we thought the button next to clone is a bit too prominent so I moved it inside the cog menu:

Not completely sure about the icon... but so far I couldn't find any better one. The import/export icons in icomoon don't look amazing either. If you have any good idea please let me know!

ThiefMaster · 2020-08-14T14:10:46Z

@meluru from our side everything is fine now and I think this PR is ready to be merged. Maybe you can have a quick look at the changes I made before I merge it?

ThiefMaster

very nice and useful feature :)

Co-authored-by: Adrian <adrian@planetcoding.net>

RHImportEventDetails is only for better UI, but we need those checks when actually running the import

It's only used in the first step, no need for it later

Depending on the timetable contents it would fail due to lack of space for everything.

It's not a feature which will be used that much compared to cloning and having it inside the menu avoids cluttering the management UI

ThiefMaster reviewed Jul 15, 2020

View reviewed changes

meluru force-pushed the wip/import-from-event branch 8 times, most recently from 2d67d84 to c24a184 Compare July 20, 2020 19:44

meluru marked this pull request as ready for review July 20, 2020 19:51

ThiefMaster requested review from plourenco and pferreir July 23, 2020 11:09

plourenco reviewed Jul 27, 2020

View reviewed changes

CHANGES.rst Outdated Show resolved Hide resolved

indico/modules/events/contributions/clone.py Outdated Show resolved Hide resolved

indico/modules/events/clone.py Outdated Show resolved Hide resolved

meluru force-pushed the wip/import-from-event branch from c24a184 to d0ce61c Compare July 29, 2020 11:34

plourenco reviewed Jul 29, 2020

View reviewed changes

CHANGES.rst Outdated Show resolved Hide resolved

indico/modules/events/editing/clone.py Outdated Show resolved Hide resolved

meluru force-pushed the wip/import-from-event branch 2 times, most recently from d1526d7 to 37dbe31 Compare July 30, 2020 09:35

plourenco approved these changes Jul 31, 2020

View reviewed changes

ThiefMaster requested changes Aug 1, 2020

View reviewed changes

meluru force-pushed the wip/import-from-event branch from 37dbe31 to 8dfbae5 Compare August 4, 2020 11:48

ThiefMaster reviewed Aug 4, 2020

View reviewed changes

indico/migrations/versions/20200804_1308_497c61b68050_fix_session_friendly_id_index.py Outdated Show resolved Hide resolved

meluru force-pushed the wip/import-from-event branch from 8dfbae5 to 1efd7c5 Compare August 6, 2020 09:32

meluru force-pushed the wip/import-from-event branch from 1efd7c5 to 5018f2c Compare August 11, 2020 10:25

meluru force-pushed the wip/import-from-event branch from 5018f2c to f1c5d02 Compare August 11, 2020 10:30

ThiefMaster force-pushed the wip/import-from-event branch from c518c62 to 0add194 Compare August 14, 2020 14:09

ThiefMaster approved these changes Aug 14, 2020

View reviewed changes

meluru and others added 19 commits August 17, 2020 10:57

Allow importing modules from another event

8cfd135

Add js util function to serialize datetime range

6bd0378

Add UI for import from event feature

2725fcd

Fix line-height of message boxes

2a90cbc

Check for conflicts with target event in cloners

3266c61

Disable cloners with conflicts in dependencies

4c59960

Add event.imported signal

79c1b5a

Add import feature to CHANGES.rst

deca869

Check for existing event persons while cloning

8d340aa

Fix issues and improve wording in import feature

ea645fc

Co-authored-by: Adrian <adrian@planetcoding.net>

Show event category chain in import dialog

5711ca7

Check for valid event when actually importing

66d8d77

RHImportEventDetails is only for better UI, but we need those checks when actually running the import

Keep original order when displaying the modules

b57c04a

Remove unnecessary field

e5523ce

It's only used in the first step, no need for it later

Prevent timetable import into shorter events

b2a1078

Depending on the timetable contents it would fail due to lack of space for everything.

Move import button to the cog menu

e408b67

It's not a feature which will be used that much compared to cloning and having it inside the menu avoids cluttering the management UI

Fix error when event persons have no user_id

7c8482d

Add icon-import to icomoon set

482b757

Use new import icon for import action

6bb2b55

ThiefMaster force-pushed the wip/import-from-event branch from 0add194 to 6bb2b55 Compare August 17, 2020 08:58

ThiefMaster merged commit 6bb2b55 into indico:master Aug 17, 2020

ThiefMaster deleted the wip/import-from-event branch August 17, 2020 09:16

ThiefMaster mentioned this pull request Jun 29, 2021

Copying timetable between events #2794

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import from event feature #4533

Import from event feature #4533

meluru commented Jul 15, 2020 •

edited

Loading

ThiefMaster left a comment

plourenco left a comment •

edited

Loading

meluru commented Jul 29, 2020

plourenco left a comment

meluru commented Jul 30, 2020

plourenco left a comment

meluru commented Aug 4, 2020

plourenco commented Aug 6, 2020

meluru commented Aug 7, 2020

meluru commented Aug 11, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster left a comment

Import from event feature #4533

Import from event feature #4533

Conversation

meluru commented Jul 15, 2020 • edited Loading

ThiefMaster left a comment

Choose a reason for hiding this comment

plourenco left a comment • edited Loading

Choose a reason for hiding this comment

meluru commented Jul 29, 2020

plourenco left a comment

Choose a reason for hiding this comment

meluru commented Jul 30, 2020

plourenco left a comment

Choose a reason for hiding this comment

meluru commented Aug 4, 2020

plourenco commented Aug 6, 2020

meluru commented Aug 7, 2020

meluru commented Aug 11, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster commented Aug 14, 2020

ThiefMaster left a comment

Choose a reason for hiding this comment

meluru commented Jul 15, 2020 •

edited

Loading

plourenco left a comment •

edited

Loading