Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IndicoDateField facilities #4535

Merged
merged 4 commits into from Jul 16, 2020

Conversation

OmeGak
Copy link
Member

@OmeGak OmeGak commented Jul 15, 2020

Added:

  • DateRange validator
  • LinkedDate validator

Improved:

  • IndicoDateField now renders with the React date picker

CHANGES.rst Outdated
- Improve ``IndicoDateField`` rendering and validators (:issue:`4535`, thanks
:user:`omegak`)
Copy link
Member

@ThiefMaster ThiefMaster Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm not sure if it's useful... it's not really relevant for end users nor plugin developers

Copy link
Member Author

@OmeGak OmeGak Jul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would still be relevant to specify that DateRange and LinkedDate validators have been added.

@OmeGak OmeGak force-pushed the wip/datefield branch 2 times, most recently from 210ac2b to be7d5c3 Compare Jul 15, 2020
indico/web/templates/forms/date_widget.html Outdated Show resolved Hide resolved
indico/web/forms/fields/datetime.py Outdated Show resolved Hide resolved
indico/web/templates/forms/date_widget.html Outdated Show resolved Hide resolved
OmeGak and others added 4 commits Jul 16, 2020
Added:
- DateRange validator
- LinkedDate validator

Improved:
- IndicoDateField now renders with the React date picker
Otherwise HiddenUnless doesn't work properly
Leats
Leats approved these changes Jul 16, 2020
Copy link
Contributor

@Leats Leats left a comment

LGTM, thank you!

@ThiefMaster ThiefMaster merged commit ba16b8b into indico:master Jul 16, 2020
4 checks passed
@OmeGak OmeGak deleted the wip/datefield branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants