Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload custom PDF for BOA #4577

Merged
merged 15 commits into from
Aug 1, 2020
Merged

Conversation

Leats
Copy link
Contributor

@Leats Leats commented Jul 31, 2020

Closes #3039.

@ThiefMaster ThiefMaster requested a review from plourenco July 31, 2020 09:36
Leats and others added 11 commits July 31, 2020 11:44
- Add a basic BoA upload widget
- Also rename some RHs and endpoint to be more meaningful now that we
  have more than one BoA-management-related one.

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
Also integrate it in the custom BoA

Co-authored-by: Lea Tschiersch <lea.tschiersch@cern.ch>
Co-authored-by: Lea Tschiersch <lea.tschiersch@cern.ch>
Copy link
Member

@plourenco plourenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, the new upload dialog works great!

And change it depending on whether or not LaTeX building is enabled in
Indico.
Otherwise we get inconsistent state when uploading a file (without
saving) and then closing and reopening the modal.
@ThiefMaster ThiefMaster merged commit 650f3f3 into indico:master Aug 1, 2020
@ThiefMaster ThiefMaster deleted the custom-boa branch August 1, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editable book of abstracts
3 participants