Prevent pending registrations from being checked-in #4646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmeGak
force-pushed
the
fix/reg-checkin
branch
from
f9f9910 to
6a1e8a5
Compare
ThiefMaster
reviewed
Oct 1, 2020
OmeGak
force-pushed
the
fix/reg-checkin
branch
from
6a1e8a5 to
c857c6e
Compare
ThiefMaster
approved these changes
Oct 1, 2020
ThiefMaster
reviewed
Oct 1, 2020
| @@ -602,6 +603,8 @@ class RHRegistrationCheckIn(RHManageRegistrationBase): | |||
| """Set checked in state of a registration""" | |||
|
|
|||
| def _process_PUT(self): | |||
| if self.registration.state not in (RegistrationState.complete, RegistrationState.unpaid): | |||
| raise BadRequest(_('Pending registration cannot be marked as checked-in')) | |||
There was a problem hiding this comment.
s/Pending/This/ since it's not necessarily pending?
ThiefMaster
changed the title
ThiefMaster
force-pushed
the
fix/reg-checkin
branch
from
c857c6e to
a248374
Compare
ThiefMaster
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.