Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pending registrations from being checked-in #4646

Merged
merged 1 commit into from Oct 9, 2020

Conversation

OmeGak
Copy link
Member

@OmeGak OmeGak commented Oct 1, 2020

No description provided.

@@ -602,6 +603,8 @@ class RHRegistrationCheckIn(RHManageRegistrationBase):
"""Set checked in state of a registration"""

def _process_PUT(self):
if self.registration.state not in (RegistrationState.complete, RegistrationState.unpaid):
raise BadRequest(_('Pending registration cannot be marked as checked-in'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Pending/This/ since it's not necessarily pending?

@ThiefMaster ThiefMaster changed the title Prevent pending registrations to be checked-in Prevent pending registrations from being checked-in Oct 5, 2020
@ThiefMaster ThiefMaster merged commit a248374 into indico:master Oct 9, 2020
@ThiefMaster ThiefMaster deleted the fix/reg-checkin branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants