Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributions placeholder for emails #4716

Merged
merged 6 commits into from Nov 23, 2020

Conversation

bpedersen2
Copy link
Contributor

Add a placeholder to list a persons contributions to an event,
optionally filtered for where the person is speaker.

indico/modules/events/persons/placeholders.py Outdated Show resolved Hide resolved
indico/modules/events/persons/placeholders.py Outdated Show resolved Hide resolved
indico/modules/events/persons/placeholders.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/util.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/util.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/util.py Outdated Show resolved Hide resolved
indico/modules/events/contributions/util.py Outdated Show resolved Hide resolved
Add a placeholder to list a persons contributions to an event,
optionally filtered for where the person is speaker.
- better naming
- sort contributions
- style fixes
- use correct formatting in placeholder info
@ThiefMaster
Copy link
Member

I made some fixes and removed the pot file update - these updates are rather noisy and likely cause rebase/merge conflicts when more than one PR updates them and we run an extraction from time to time anyway.

The friendly param name is not needed when showing only the explicit
versions from iter_param_info.
@ThiefMaster ThiefMaster merged commit 86549dd into indico:2.3-maintenance Nov 23, 2020
@bpedersen2
Copy link
Contributor Author

@ThiefMaster , many thanks for the review input and your updates! Looks nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants