Add contributions placeholder for emails #4716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
requested changes
Nov 20, 2020
bpedersen2
force-pushed
the
contribs_placeholder
branch
from
1fcc40d to
07d5ad6
Compare
Add a placeholder to list a persons contributions to an event, optionally filtered for where the person is speaker.
ThiefMaster
force-pushed
the
contribs_placeholder
branch
from
4fcd188 to
7cbcf47
Compare
- better naming - sort contributions - style fixes - use correct formatting in placeholder info
ThiefMaster
force-pushed
the
contribs_placeholder
branch
from
7cbcf47 to
6f0b07a
Compare
|
I made some fixes and removed the pot file update - these updates are rather noisy and likely cause rebase/merge conflicts when more than one PR updates them and we run an extraction from time to time anyway. |
The friendly param name is not needed when showing only the explicit versions from iter_param_info.
ThiefMaster
approved these changes
Nov 23, 2020
|
@ThiefMaster , many thanks for the review input and your updates! Looks nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a placeholder to list a persons contributions to an event,
optionally filtered for where the person is speaker.