Expose links the user can access #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Nov 20, 2020
ThiefMaster
reviewed
Nov 20, 2020
ThiefMaster
reviewed
Nov 24, 2020
ThiefMaster
reviewed
Nov 24, 2020
Optimise the access check condition
ThiefMaster
force-pushed
the
link-material
branch
from
bf58ebb
to
f2f4d53
Compare
ThiefMaster
pushed a commit
that referenced
this pull request
Nov 24, 2020
Link materials now use direct links so users can see the target URL. In case someone has no access to a link we still go through the download endpoint in order to trigger a proper access-denied page (or the redirect to login).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2599
Uses the simplistic approach where links are visible if the user has permissions on them. It causes an access check on our side for every button, but realistically I'm assuming no impact while doing that.
We also considered creating an Indico redirector (could even contain a signature to avoid malicious access) but concluded it could become a burden for a simple use-case.
View with permissions (the redirection is immediate):
View without permission (the redirection goes through the server):
