Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some user agents from sso redirection #4731

Merged
merged 1 commit into from Mar 5, 2021

Conversation

plourenco
Copy link
Member

Closes #4720

@plourenco plourenco changed the base branch from master to 2.3-maintenance November 30, 2020 16:01
indico/modules/auth/controllers.py Outdated Show resolved Hide resolved
indico/modules/auth/controllers.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster marked this pull request as ready for review March 5, 2021 12:28
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce it on my local instance anymore (MS Office only sends HTTP HEAD which 400s anyway), but the logic works fine so I don't see any reason to not merge this.

@ThiefMaster ThiefMaster merged commit 3f1bba6 into indico:2.3-maintenance Mar 5, 2021
@ThiefMaster ThiefMaster deleted the ms-office branch March 5, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO Authentication is incorrectly redirected within MS Office
2 participants