Skip to content

New option for Modification allowed settings in Registration #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 10, 2020
Merged

New option for Modification allowed settings in Registration #4740

merged 18 commits into from
Dec 10, 2020

Conversation

vasantvohra
Copy link
Contributor

@vasantvohra vasantvohra commented Dec 9, 2020 •
edited
Loading

  • Add a new Until approved option for a registration form's "Modification allowed" settings.

@vasantvohra vasantvohra changed the title Disable modify Modification allowed until Approved Dec 9, 2020
@vasantvohra vasantvohra changed the title Modification allowed until Approved Modification allowed until approved Dec 9, 2020
ThiefMaster
ThiefMaster requested changes Dec 9, 2020
View reviewed changes
ThiefMaster
ThiefMaster reviewed Dec 9, 2020
View reviewed changes
@vasantvohra @ThiefMaster
Update indico/migrations/versions/20201209_2010_e4fb983dc64c_modifica…
ff3ac5d 
…tion_mode_enum.py

Co-authored-by: Adrian <adrian@planetcoding.net>
@vasantvohra vasantvohra changed the title Modification allowed until approved New option to Modification allowed 'While pending approval' settings Dec 9, 2020
@vasantvohra vasantvohra changed the title New option to Modification allowed 'While pending approval' settings New option for Modification allowed settings in Registration Form Dec 9, 2020
@vasantvohra vasantvohra changed the title New option for Modification allowed settings in Registration Form New option for Modification allowed settings in Registration Dec 10, 2020
ThiefMaster
ThiefMaster requested changes Dec 10, 2020
View reviewed changes
vasantvohra and others added 3 commits December 10, 2020 18:17
@vasantvohra @ThiefMaster
Update indico/migrations/versions/20201209_2010_e4fb983dc64c_modifica…
b5bd022 
…tion_mode_enum.py

Co-authored-by: Adrian <adrian@planetcoding.net>
@vasantvohra @ThiefMaster
Update indico/migrations/versions/20201209_2010_e4fb983dc64c_modifica…
846e0fb 
…tion_mode_enum.py

Co-authored-by: Adrian <adrian@planetcoding.net>
@vasantvohra
Add new 'While pending approval' option
2a78624
@pferreir
Copy link
Member

Would it perhaps make more sense to call the option "untill approved"? It's more consistent with the others, IMO.

@vasantvohra
Copy link
Contributor Author

Would it perhaps make more sense to call the option "untill approved"? It's more consistent with the others, IMO.

I totally agree but it was @ThiefMaster or @OmeGak suggestion

@ThiefMaster
Copy link
Member

Yeah, that's what it was initially, I had suggested "while pending" since it may be clearer since we show registrations as "pending", and I'm not sure how clear it is for people what an "approved" registration means (especially in case moderation isn't used).

@pferreir
Copy link
Member

I'm not sure how clear it is for people what an "approved" registration means

Fair enough. I actually find it less clear, since all other options specify an "until" and this one a "while". But yeah, we'll see whether people get it or not...

@ThiefMaster
Copy link
Member

I don't have a strong opinion on this btw, so fine either way. It's right that keeping "until ..." is more consistent.

@vasantvohra
Copy link
Contributor Author

Here you go @pferreir ..

@pferreir
Copy link
Member

Here you go @pferreir ..

Great, thanks!

pferreir
pferreir approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@pferreir pferreir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR!

@vasantvohra
Copy link
Contributor Author

vasantvohra commented Dec 10, 2020 •
edited
Loading

Thanks a lot for the PR!
@pferreir, can you squash & merge as "I'm getting Only those with write access to this repository can merge pull requests."?

ThiefMaster
ThiefMaster reviewed Dec 10, 2020
View reviewed changes
@ThiefMaster ThiefMaster merged commit 8c28c5a into indico:2.3-maintenance Dec 10, 2020
@ThiefMaster ThiefMaster deleted the disable_modify branch December 10, 2020 14:07
@ThiefMaster
Copy link
Member

ugh somehow the alembic revision disappeared from your PR... i'll forcepush to fix that

@vasantvohra vasantvohra restored the disable_modify branch December 10, 2020 14:09
ThiefMaster pushed a commit that referenced this pull request Dec 10, 2020
@vasantvohra @ThiefMaster
Add "until approved" regform modification setting (#4740)
f80f314
@vasantvohra
Copy link
Contributor Author

Thanks a ton, @pferreir and @ThiefMaster,
Happy holidays will probably disturb in the new year (2021) now 💯

vasantvohra added a commit to UNOG-Indico/indico-core that referenced this pull request Dec 10, 2020
@vasantvohra
Add "until approved" regform modification setting (indico#4740)
a9464da
vasantvohra added a commit to UNOG-Indico/indico-core that referenced this pull request Dec 10, 2020
@vasantvohra
Add "until approved" regform modification setting (indico#4740)
3701934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pferreir pferreir pferreir approved these changes

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasantvohra @pferreir @ThiefMaster