Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache JS i18n data for invalid locales #4766

Merged

Conversation

ThiefMaster
Copy link
Member

No description provided.

@ThiefMaster ThiefMaster added this to the v2.3 milestone Jan 23, 2021
@ThiefMaster ThiefMaster added this to In progress in Release 2.3 via automation Jan 23, 2021
@ThiefMaster ThiefMaster moved this from In progress to Review in progress in Release 2.3 Jan 23, 2021
Otherwise each request for an invalid locale will create a cache file.
Security scanners and similar tools may request a lot of invalid locales,
and thus create a large amount of small but useless files in the cache
folder (which are eventually cleaned up but not creating them to begin
with is clearly better).
@ThiefMaster ThiefMaster merged commit 5aed14e into indico:2.3-maintenance Jan 25, 2021
Release 2.3 automation moved this from Review in progress to Done Jan 25, 2021
@ThiefMaster ThiefMaster deleted the fix-invalid-js-locales branch January 25, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant