Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk export for editing data to JSON #4810

Merged
merged 1 commit into from Mar 9, 2021

Conversation

ThiefMaster
Copy link
Member

closes #4767

@ThiefMaster ThiefMaster added this to the v3 milestone Mar 5, 2021
@ThiefMaster ThiefMaster added this to In progress in Release 3.0 via automation Mar 5, 2021
Copy link
Member

@plourenco plourenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine!

Not sure for how long the

f for f in EditableSchema.Meta.fields if not f.startswith('can_')

is going to hold for, if somehow the EditableSchema is changed and something may go in here. But I'm guessing you also assumed it's fine for now.

Release 3.0 automation moved this from In progress to Awaiting review/merge Mar 5, 2021
@ThiefMaster
Copy link
Member Author

I think if we add new attributes to that schema there's a good chance they are worth including in the export as well.

I'm just excluding those can_* attributes because anything about the current user's permissions is completely useless when exporting data to use outside Indico.

@ThiefMaster ThiefMaster merged commit 05e9bc4 into indico:master Mar 9, 2021
4 checks passed
Release 3.0 automation moved this from Awaiting review/merge to Done Mar 9, 2021
@ThiefMaster ThiefMaster deleted the editable-dump-json branch June 16, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 3.0
  
Done
Development

Successfully merging this pull request may close these issues.

Bulk JSON dump for Editing / Paper Peer Reviewing modules
2 participants