Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration CSV import: Check for unique users as well #4823

merged 1 commit into from Mar 22, 2021


Copy link

We check for unique emails but if two emails belong to the same user the import still fails with an ugly database error.

@ThiefMaster ThiefMaster added this to the v3 milestone Mar 15, 2021
@ThiefMaster ThiefMaster added this to To do in Release 3.0 via automation Mar 15, 2021
@ThiefMaster ThiefMaster self-assigned this Mar 19, 2021
@ThiefMaster ThiefMaster moved this from To do to Awaiting review/merge in Release 3.0 Mar 19, 2021
if email in used_emails:
raise UserValueError(_('Row {}: email address is not unique').format(row_num))
if conflict_row_num := email_row_map.get(email):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲 shiny new assignment operator!

@ThiefMaster ThiefMaster merged commit 28d986f into indico:master Mar 22, 2021
Release 3.0 automation moved this from Awaiting review/merge to Done Mar 22, 2021
@ThiefMaster ThiefMaster deleted the reg-import-user-dupe-check branch March 22, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
No open projects
Release 3.0

Successfully merging this pull request may close these issues.

None yet

2 participants