Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "show inherited ACL" functionality #4833

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

ThiefMaster
Copy link
Member

This got lost at some point, probably when we switched to the fancy "permissions widget" in v2.1. Apparently nobody missed it but I spotted it when removing some unused code and thus fixed it.

For those who don't remember it, it's this:

image

image

@ThiefMaster ThiefMaster added this to the v3 milestone Mar 18, 2021
@ThiefMaster ThiefMaster added this to In progress in Release 3.0 via automation Mar 18, 2021
@ThiefMaster ThiefMaster moved this from In progress to Awaiting review/merge in Release 3.0 Mar 18, 2021
@ThiefMaster ThiefMaster requested a review from javfg March 22, 2021 09:20
- show the message about inherited access again
- properly show each acl type when viewing the list
- remove obsolete code
Using the enum is much cleaner, and they were only used in few places
(which are now using the principal_type).
@ThiefMaster ThiefMaster merged commit 64ee03f into indico:master Mar 22, 2021
Release 3.0 automation moved this from Awaiting review/merge to Done Mar 22, 2021
@ThiefMaster ThiefMaster deleted the inheriting-acls branch June 16, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 3.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants