Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contribution page access with explicit ACL entry and no event access #4860

Merged
merged 4 commits into from Apr 9, 2021

Conversation

ThiefMaster
Copy link
Member

#4857 fixed the problem for the timetable bubble, but the (sub)contribution detail pages had the same issue.

also, I noticed that the registration menu item was always visible even if you could not access it, so that's fixed now as well.

@ThiefMaster ThiefMaster added this to the v2.3 milestone Apr 9, 2021
@ThiefMaster ThiefMaster added this to In progress in Release 2.3 via automation Apr 9, 2021
@ThiefMaster ThiefMaster changed the title Contrib access Fix contribution page access with explicit ACL entry and no event access Apr 9, 2021
ie a user who cannot access the event itself but is on the ACL for
a contribution
When an event is protected and the user has only access to a specific
session/contribution inside, it makes no sense to show the registration
menu unless the registrations are actually available to people with no
event access.
We still have the blank area, but avoid showing just the border of the
menu list.
@ThiefMaster ThiefMaster enabled auto-merge (rebase) April 9, 2021 13:23
@ThiefMaster ThiefMaster merged commit 4957d92 into indico:2.3-maintenance Apr 9, 2021
Release 2.3 automation moved this from In progress to Done Apr 9, 2021
@ThiefMaster ThiefMaster deleted the contrib-access branch June 16, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant