Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to keep Editing team anonymous #4865

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented Apr 12, 2021

image

closes #4829

@ThiefMaster ThiefMaster added this to the v2.3 milestone Apr 12, 2021
@ThiefMaster ThiefMaster added this to In progress in Release 2.3 via automation Apr 12, 2021
@ThiefMaster ThiefMaster moved this from In progress to Review in progress in Release 2.3 Apr 12, 2021
@ThiefMaster ThiefMaster force-pushed the anonymous-editors branch 3 times, most recently from 4c96569 to eb852ba Compare April 12, 2021 12:12
@@ -14,13 +14,14 @@ function UserAvatar({user}) {
className="i-timeline-item-label avatar-placeholder"
style={{backgroundColor: user.avatarBgColor}}
>
{user.fullName[0]}
{user.anonymous ? '' : user.fullName[0]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could check if the id is -1 and probably skip having an anonymous attribute
(as it seems to be just for the avatar)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this initially; but I preferred being more explicit in the end. The only reason I'm sending the -1 id (instead of null) is to make PropTypes happy without finding every single place where we're using it or passing it along ;)

Release 2.3 automation moved this from Review in progress to Reviewer approved Apr 12, 2021
@ThiefMaster ThiefMaster merged commit ace6a63 into indico:2.3-maintenance Apr 12, 2021
Release 2.3 automation moved this from Reviewer approved to Done Apr 12, 2021
@ThiefMaster ThiefMaster deleted the anonymous-editors branch April 12, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 2.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants