Fix character count inconsistencies while dealing with line breaks #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 26, 2021
|
IMO this change deserves a changelog entry (in bugfixes): - Correctly count line breaks in length-limited abstracts (:pr:`4918`) |
plourenco
force-pushed
the
soft-length
branch
2 times, most recently
from
7ea3314 to
51ce1d6
Compare
ThiefMaster
reviewed
May 26, 2021
ThiefMaster
reviewed
May 26, 2021
Co-authored-by: Adrian <adrian@planetcoding.net>
ThiefMaster
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first went for a client-sided approach (fix it before sending), but it's not that easy with multiple change listeners. Then I noticed on top of that we have a SoftLength validator which seemed like a good candidate to accept line-breaks as a single character.