Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix character count inconsistencies while dealing with line breaks #4918

Merged
merged 4 commits into from Jun 1, 2021

Conversation

plourenco
Copy link
Member

May-26-2021 16-13-57

I first went for a client-sided approach (fix it before sending), but it's not that easy with multiple change listeners. Then I noticed on top of that we have a SoftLength validator which seemed like a good candidate to accept line-breaks as a single character.

@ThiefMaster
Copy link
Member

IMO this change deserves a changelog entry (in bugfixes):

- Correctly count line breaks in length-limited abstracts (:pr:`4918`)

@plourenco plourenco force-pushed the soft-length branch 2 times, most recently from 7ea3314 to 51ce1d6 Compare May 26, 2021 16:08
Co-authored-by: Adrian <adrian@planetcoding.net>
@ThiefMaster ThiefMaster merged commit 2359a05 into indico:master Jun 1, 2021
@ThiefMaster ThiefMaster deleted the soft-length branch June 1, 2021 09:17
plourenco added a commit to plourenco/indico that referenced this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants