Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show external contribution references in conferences #4933

Merged
merged 3 commits into from Jun 4, 2021

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jun 4, 2021

Shows external references on contribution and subcontribution pages.

Contribution detail:
Screenshot from 2021-06-04 13-59-58
Subcontribution detail:
Screenshot from 2021-06-04 14-02-28

The function render_references() now shows the references differently based on whether the references are in a meeting or a conference. The function takes an extra parameter class which specifies additional styles to be applied. The default value applies the meeting styles so other code does not need to be modified. For (sub)contributions, the function is used as render_references(contrib, 'reference-list-conference').

The related css classes are moved from _meetings.scss to _common.scss.

closes #4928

Add a new section with external references to contribution and subcontribution pages.
@tomasr8 tomasr8 requested a review from ThiefMaster June 4, 2021 12:36
@tomasr8 tomasr8 changed the title Show external contribution references in conferences #4928 Show external contribution references in conferences Jun 4, 2021
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR :)

@ThiefMaster ThiefMaster added this to the v3 milestone Jun 4, 2021
@ThiefMaster ThiefMaster added this to In progress in Release 3.0 via automation Jun 4, 2021
@ThiefMaster ThiefMaster merged commit 2996f51 into indico:master Jun 4, 2021
Release 3.0 automation moved this from In progress to Done Jun 4, 2021
@tomasr8 tomasr8 deleted the show-external-reference branch June 4, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 3.0
  
Done
Development

Successfully merging this pull request may close these issues.

External IDs in contributions not shown on conference contribution pages
2 participants