Fix PDF timetable breaking when 'print abstracts' option is set#4955
Merged
ThiefMaster merged 6 commits intoindico:masterfrom Jun 21, 2021
Merged
Fix PDF timetable breaking when 'print abstracts' option is set#4955ThiefMaster merged 6 commits intoindico:masterfrom
ThiefMaster merged 6 commits intoindico:masterfrom
Conversation
ThiefMaster
reviewed
Jun 18, 2021
Member
ThiefMaster
left a comment
ThiefMaster
left a comment
There was a problem hiding this comment.
I only skimmed the diff (legacy code after all...) but AFAICT it looks good. So if it works fine I think it's good to go
Co-authored-by: Adrian <adrian@planetcoding.net>
javfg
force-pushed
the
pdfexport-fix
branch
2 times, most recently
from
a2f665a to
d22770a
Compare
ThiefMaster
approved these changes
Jun 21, 2021
plourenco
pushed a commit
to plourenco/indico
that referenced
this pull request
Jul 6, 2021
* Fix PDF timetable breaking when abstracts are included * Widen poster board column so header fits in one line
pferreir
pushed a commit
to pferreir/indico
that referenced
this pull request
Oct 12, 2021
* Fix PDF timetable breaking when abstracts are included * Widen poster board column so header fits in one line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the layout of the timetable PDF when the advanced option 'Print abstract content of all contributions' is selected.
ReportLab is unable to split table rows when the content is bigger than the page it's placed upon, as described by the discussion linked in the bug report by @bcc.
To overcome this limitation, the timetable will not be contained in a table if the option to print the abstracts is set. The document is slightly different, but still provides the same information. If that option is unset, the previous layout persists.
Closes #4881.