Properly remember anonymous survey submissions#4970
Merged
ThiefMaster merged 8 commits intoindico:masterfrom Jun 30, 2021
Merged
Properly remember anonymous survey submissions#4970ThiefMaster merged 8 commits intoindico:masterfrom
ThiefMaster merged 8 commits intoindico:masterfrom
Conversation
ThiefMaster
reviewed
Jun 30, 2021
ThiefMaster
reviewed
Jun 30, 2021
javfg
force-pushed
the
keep-surveys-anonymous
branch
from
61b6f80 to
fbe503f
Compare
ThiefMaster
reviewed
Jun 30, 2021
Co-authored-by: Adrian <adrian@planetcoding.net>
Co-authored-by: Adrian <adrian@planetcoding.net>
javfg
force-pushed
the
keep-surveys-anonymous
branch
from
3610064 to
0a1ed64
Compare
ThiefMaster
reviewed
Jun 30, 2021
ThiefMaster
reviewed
Jun 30, 2021
Co-authored-by: Adrian <adrian@planetcoding.net>
plourenco
pushed a commit
to plourenco/indico
that referenced
this pull request
Jul 6, 2021
pferreir
pushed a commit
to pferreir/indico
that referenced
this pull request
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #4693.
The solution implemented is the first one proposed in there: store the pair
survey_id,user_idfor anonymous submissions in a new table. This disables users to vote again by logging out and in again, while keeping anonymity for the surveys. But it's possible to determine who has submitted a survey when only a few people have done it.