Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly remember anonymous survey submissions #4970

Merged
merged 8 commits into from
Jun 30, 2021

Conversation

javfg
Copy link
Contributor

@javfg javfg commented Jun 30, 2021

This PR closes #4693.

The solution implemented is the first one proposed in there: store the pair survey_id, user_id for anonymous submissions in a new table. This disables users to vote again by logging out and in again, while keeping anonymity for the surveys. But it's possible to determine who has submitted a survey when only a few people have done it.

@javfg javfg marked this pull request as ready for review June 30, 2021 14:28
CHANGES.rst Outdated Show resolved Hide resolved
indico/modules/events/surveys/controllers/display.py Outdated Show resolved Hide resolved
indico/modules/events/surveys/util.py Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrian <adrian@planetcoding.net>
@ThiefMaster ThiefMaster merged commit e7e00b9 into indico:master Jun 30, 2021
@ThiefMaster ThiefMaster deleted the keep-surveys-anonymous branch June 30, 2021 16:21
plourenco pushed a commit to plourenco/indico that referenced this pull request Jul 6, 2021
pferreir pushed a commit to pferreir/indico that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anonymous votes can be re-submitted by the same user
2 participants