Implement flat category view #4983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmeGak
force-pushed
the
wip/flatcat
branch
10 times, most recently
from
722d4d3 to
3f97f9b
Compare
OmeGak
force-pushed
the
wip/flatcat
branch
8 times, most recently
from
00b98cb to
07b7395
Compare
ThiefMaster
reviewed
Jul 6, 2021
ThiefMaster
reviewed
Jul 6, 2021
ThiefMaster
force-pushed
the
wip/flatcat
branch
2 times, most recently
from
a304784 to
3239d6f
Compare
OmeGak
force-pushed
the
wip/flatcat
branch
2 times, most recently
from
cf3a364 to
689fc1a
Compare
This happened because is_visible_in never includes hidden events, but we were still explicitly looking for (nested) hidden events, and then showing the warning about event being hidden from the list, but only for non-admin/non-manager users.
ThiefMaster
approved these changes
Jul 6, 2021
|
Great Job @OmeGak, @ThiefMaster, @openprojects 👍 |
OmeGak
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 7, 2021
-- BACKPORT NOTICE ----------------------------------------------------- This feature was backported from v3 and adapted to not require a database migration. This commit needs to be removed when rebasing onto upstream master. ------------------------------------------------------------------------ * Implement flat category view * Do not show deleted events * Avoid misleading hidden event message in flat view This happened because is_visible_in never includes hidden events, but we were still explicitly looking for (nested) hidden events, and then showing the warning about event being hidden from the list, but only for non-admin/non-manager users. * Fix eslint warnings * Do not auto-load past/future events in flat view Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
OmeGak
added a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 12, 2021
-- BACKPORT NOTICE ----------------------------------------------------- This feature was backported from v3 and adapted to not require a database migration. This commit needs to be removed when rebasing onto upstream master. ------------------------------------------------------------------------ * Implement flat category view * Do not show deleted events * Avoid misleading hidden event message in flat view This happened because is_visible_in never includes hidden events, but we were still explicitly looking for (nested) hidden events, and then showing the warning about event being hidden from the list, but only for non-admin/non-manager users. * Fix eslint warnings * Do not auto-load past/future events in flat view Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
vasantvohra
pushed a commit
to UNOG-Indico/indico-core
that referenced
this pull request
Jul 13, 2021
-- BACKPORT NOTICE ----------------------------------------------------- This feature was backported from v3 and adapted to not require a database migration. This commit needs to be removed when rebasing onto upstream master. ------------------------------------------------------------------------ * Implement flat category view * Do not show deleted events * Avoid misleading hidden event message in flat view This happened because is_visible_in never includes hidden events, but we were still explicitly looking for (nested) hidden events, and then showing the warning about event being hidden from the list, but only for non-admin/non-manager users. * Fix eslint warnings * Do not auto-load past/future events in flat view Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
pferreir
pushed a commit
to pferreir/indico
that referenced
this pull request
Oct 12, 2021
* Implement flat category view * Do not show deleted events * Avoid misleading hidden event message in flat view This happened because is_visible_in never includes hidden events, but we were still explicitly looking for (nested) hidden events, and then showing the warning about event being hidden from the list, but only for non-admin/non-manager users. * Fix eslint warnings * Do not auto-load past/future events in flat view Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4982.