New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Automatic notifications to consider notification sender address #4996
Conversation
Maybe removing this logic from |
I see reply-to address there, so should I replace event.contact_emails[0] if event.contact_emails else '' with config.NO_REPLY_EMAIL ? |
no, just set it to |
156befa
to
9a9d489
Compare
A changelog entry would be useful for this (bugfixes section i guess, that's the most suitable one IMO): - No longer silently fall back to the first event contact email address when sending
registration emails where no explicit sender address has been configured (:issue:`4992`,
:pr:`4996`, thanks :user:`vasantvohra`) for the abstract notification templates I don't think it's needed since it only affects newly created ones |
9a9d489
to
21d88c3
Compare
21d88c3
to
17d464f
Compare
…or by default config.NO_REPLY_EMAIL
17d464f
to
e3df9c6
Compare
This wasn't documented anywhere and rather confusing behavior.
This wasn't documented anywhere and rather confusing behavior.
This wasn't documented anywhere and rather confusing behavior.
This wasn't documented anywhere and rather confusing behavior.
This wasn't documented anywhere and rather confusing behavior.
This wasn't documented anywhere and rather confusing behavior.
This wasn't documented anywhere and rather confusing behavior.
closes #4992
changes.rst