Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Registration details permissions for protected events #4997

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

vasantvohra
Copy link
Contributor

closes #4991

@vasantvohra vasantvohra marked this pull request as draft July 7, 2021 12:21
@vasantvohra vasantvohra marked this pull request as ready for review July 7, 2021 14:12
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded the changelog entry a bit and update another check that was causing errors when accessing a registration with a token end editing it (if modification is enabled)

@ThiefMaster ThiefMaster enabled auto-merge (squash) July 7, 2021 17:14
@ThiefMaster ThiefMaster merged commit 39ed947 into indico:master Jul 7, 2021
@vasantvohra
Copy link
Contributor Author

I reworded the changelog entry a bit and update another check that was causing errors when accessing a registration with a token end editing it (if modification is enabled)

Thanks a lot, @ThiefMaster :). Thanks for your availability and quick responses :)

@vasantvohra vasantvohra deleted the fix/registration-details branch July 7, 2021 17:51
vasantvohra added a commit to UNOG-Indico/indico-core that referenced this pull request Jul 8, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
vasantvohra added a commit to UNOG-Indico/indico-core that referenced this pull request Jul 9, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
vasantvohra added a commit to UNOG-Indico/indico-core that referenced this pull request Jul 9, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
OmeGak pushed a commit to UNOG-Indico/indico-core that referenced this pull request Jul 12, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
OmeGak pushed a commit to UNOG-Indico/indico-core that referenced this pull request Jul 13, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
vasantvohra added a commit to UNOG-Indico/indico-core that referenced this pull request Jul 13, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
pferreir pushed a commit to pferreir/indico that referenced this pull request Oct 12, 2021
* Fix: Registration details permissions for protected events
* Improve changelog message
* Fix access error when editing registration in restricted event

Co-authored-by: Adrian Moennich <adrian.moennich@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protected Event Registration Details for non-Indico accounts.
2 participants