Remove wildcard import of signals.core into signals #5007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
force-pushed
the
core-signals
branch
from
278f34e to
9d611d7
Compare
ThiefMaster
force-pushed
the
core-signals
branch
from
9d611d7 to
e62be80
Compare
ThiefMaster
added a commit
to indico/indico-plugins
that referenced
this pull request
Jul 13, 2021
ThiefMaster
added a commit
to indico/indico-plugins-cern
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signals.corewas the only module inside signals that did this, and wildcard imports are pretty messy to begin with...