Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlisted events #5023

Merged
merged 42 commits into from
Sep 24, 2021
Merged

Unlisted events #5023

merged 42 commits into from
Sep 24, 2021

Conversation

javfg
Copy link
Contributor

@javfg javfg commented Jul 28, 2021

Unlisted events (#4294)

This PR includes the following tasks:

Backend changes

  • Support events with no category / category_id in the DB (nullable column).
  • Fix all problems arising after making category nullable in the event object.

Updating existing UI (following these mockups)

  • Unlisted event creation.
  • Update event management/display view to indicate an event is unlisted.
  • Unlisted event "publishing" (wording might change).

Listing unlisted events

  • Create a new dashboard area showing the unlisted events for the user.

Additional stuff we should look into:

  • When cloning an event, having the new one be an unlisted event should be an option.

@javfg javfg added this to In progress in Release 3.1 via automation Jul 28, 2021
@javfg javfg self-assigned this Aug 4, 2021
@javfg javfg force-pushed the unlisted-events branch 3 times, most recently from 1b37ab1 to 08ed8e9 Compare August 24, 2021 14:50
@javfg javfg requested a review from ThiefMaster August 24, 2021 15:28
indico/modules/events/forms.py Outdated Show resolved Hide resolved
indico/modules/events/management/client/js/EventMove.jsx Outdated Show resolved Hide resolved
indico/modules/events/management/client/js/EventMove.jsx Outdated Show resolved Hide resolved
indico/modules/events/management/client/js/EventMove.jsx Outdated Show resolved Hide resolved
indico/modules/events/management/client/js/EventMove.jsx Outdated Show resolved Hide resolved
indico/modules/users/util.py Outdated Show resolved Hide resolved
indico/web/breadcrumbs.py Outdated Show resolved Hide resolved
indico/modules/users/templates/dashboard.html Outdated Show resolved Hide resolved
indico/modules/users/templates/dashboard.html Outdated Show resolved Hide resolved
indico/modules/categories/util.py Outdated Show resolved Hide resolved
indico/modules/events/management/client/js/EventMove.jsx Outdated Show resolved Hide resolved
indico/modules/events/management/controllers/protection.py Outdated Show resolved Hide resolved
indico/modules/events/management/forms.py Outdated Show resolved Hide resolved
indico/modules/events/models/events.py Outdated Show resolved Hide resolved
indico/modules/users/templates/dashboard.html Outdated Show resolved Hide resolved
indico/web/breadcrumbs.py Outdated Show resolved Hide resolved
@ThiefMaster
Copy link
Member

Right now selecting a category is required when cloning an event. Should we keep it as it is or allow cloning as unlisted? (in any case this is not something for this PR, just something I realized when testing whether the clone form works ;))

@javfg
Copy link
Contributor Author

javfg commented Sep 13, 2021

Right now selecting a category is required when cloning an event. Should we keep it as it is or allow cloning as unlisted? (in any case this is not something for this PR, just something I realized when testing whether the clone form works ;))

I think we should allow cloning as unlisted. I mentioned it in the initial post but I agree it's for another PR.

@javfg javfg marked this pull request as ready for review September 14, 2021 15:20
@javfg javfg force-pushed the unlisted-events branch 2 times, most recently from 60d2015 to fafba76 Compare September 15, 2021 09:22
@javfg javfg moved this from In progress to Awaiting review/merge in Release 3.1 Sep 21, 2021
@ThiefMaster ThiefMaster merged commit 3b87793 into indico:master Sep 24, 2021
Release 3.1 automation moved this from Awaiting review/merge to Done Sep 24, 2021
@ThiefMaster ThiefMaster deleted the unlisted-events branch September 24, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants